public inbox for fortran@gcc.gnu.org
 help / color / mirror / Atom feed
From: mscfd <mscfd@gmx.net>
To: fortran@gcc.gnu.org
Subject: Data race within write intrinsic with output into a character variable
Date: Wed, 10 Mar 2021 21:40:26 +0100	[thread overview]
Message-ID: <trinity-b8643f61-44c1-4166-a524-b8d5e3d60ed9-1615408826064@3c-app-gmx-bap07> (raw)

Sorry for the noise, but line breaks and subject
were somehow missing...

> which version of gfortran, and which operating system?
I have seen this on two different Linux distros on x86
with a recently compiled version, but also some
time ago with an older gfortran 10 version.

Using helgrind on a simple omp do loop with write to
a character variable, I get some possible data races
in libgfortran/io/unit.c. There global array newunits is
allocated and possibly reallocated in
"newunit_alloc". According to the lock outputs from
helgrind I see that this routine is called even if
output is into a character variable. Routine
"newunit_alloc" uses a lock to avoid having several
threads all over the place. But newunit_free also
writes to newunits array. And this routine does not
obtain a lock itself (see comment above newunit_free
in unit.c) So in theory it can happen that newunit_alloc
reallocated newunits, and newunit_free writes to it just
at this time. As I also use 18 threads the initial size of 16
does not suffice and reallocation does probably
indeed happen.
Also acces to newunit_lwi is not protected as well
(and complained about by helgrind).
 
Could it be that the corresponding write routine in
transfer.c which calls newunit_free does not obtain
the necessary lock. I cannot find it (which does not
count for much).
 
Any thoughts?
Martin


             reply	other threads:[~2021-03-10 20:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-10 20:40 mscfd [this message]
2021-03-10 21:38 ` Tobias Burnus
  -- strict thread matches above, loose matches on Subject: below --
2021-03-10 11:35 Martin Stein
2021-03-10 15:41 ` Kay Diederichs

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=trinity-b8643f61-44c1-4166-a524-b8d5e3d60ed9-1615408826064@3c-app-gmx-bap07 \
    --to=mscfd@gmx.net \
    --cc=fortran@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).