From: Harald Anlauf <anlauf@gmx.de>
To: Thomas Koenig <tkoenig@netcologne.de>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>, fortran <fortran@gcc.gnu.org>
Subject: Re: *Ping*: [PATCH] PR fortran/96711 - ICE on NINT() Function
Date: Mon, 7 Sep 2020 21:46:19 +0200 [thread overview]
Message-ID: <trinity-c0e2c515-74c7-47c5-a73a-6d2056b6aca3-1599507979593@3c-app-gmx-bs55> (raw)
In-Reply-To: <3e6df45e-6270-d6eb-dcf0-0dee57158d66@netcologne.de>
Hi Thomas,
thanks for the review!
> Regarding the patch: Could you change the test caes into a
> run-time test and check for the results both for compile-time
> simplification and evaluation at run-time? Just to make sure that
> fold_convert wasn't trying to tell us something that convert doesn't...
>
> OK with that change.
Here's the test I committed:
! { dg-do run }
! { dg-require-effective-target fortran_integer_16 }
! { dg-require-effective-target fortran_real_16 }
! { dg-additional-options "-fdump-tree-original" }
! { dg-final { scan-tree-dump-times "_gfortran_stop_numeric" 2 "original" } }
!
! PR fortran/96711 - ICE on NINT() Function
program p
implicit none
real(8) :: x
real(16) :: y
integer(16), parameter :: k1 = nint (2 / epsilon (x), kind(k1))
integer(16), parameter :: k2 = nint (2 / epsilon (y), kind(k2))
integer(16), parameter :: m1 = 9007199254740992_16 !2**53
integer(16), parameter :: m2 = 10384593717069655257060992658440192_16 !2**113
integer(16), volatile :: m
x = 2 / epsilon (x)
y = 2 / epsilon (y)
m = nint (x, kind(m))
! print *, m
if (k1 /= m1) stop 1
if (m /= m1) stop 2
m = nint (y, kind(m))
! print *, m
if (k2 /= m2) stop 3
if (m /= m2) stop 4
end program
Harald
prev parent reply other threads:[~2020-09-07 19:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-24 21:08 Harald Anlauf
2020-09-03 18:42 ` *Ping*: " Harald Anlauf
2020-09-07 5:09 ` Thomas Koenig
2020-09-07 19:46 ` Harald Anlauf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=trinity-c0e2c515-74c7-47c5-a73a-6d2056b6aca3-1599507979593@3c-app-gmx-bs55 \
--to=anlauf@gmx.de \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=tkoenig@netcologne.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).