From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.17.20]) by sourceware.org (Postfix) with ESMTPS id 6F5123858C55; Tue, 20 Sep 2022 20:35:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6F5123858C55 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmx.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1663706104; bh=hn5vU2uIdLWSannTtAXD/8L+9ycIPPJIBZ25CAKnh2g=; h=X-UI-Sender-Class:From:To:Subject:Date; b=gvFS53Kv57h9IjxzksA56c2+gyBJizRlKMyFT6Jtt9dRF+CTsp+YAK/ON3JTVfr+/ MjHMuGd1FLB0o3eGXZFUFcDtSnuTNQgrFE4x9N49TWbjHCZIBd1cVbyVBygcD/BSTi eg3zU4c5b/C9xpHb2Ohuj2IyUA8bMi/HQ/nJ1RoY= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [93.207.88.67] ([93.207.88.67]) by web-mail.gmx.net (3c-app-gmx-bap12.server.lan [172.19.172.82]) (via HTTP); Tue, 20 Sep 2022 22:35:04 +0200 MIME-Version: 1.0 Message-ID: From: Harald Anlauf To: fortran , gcc-patches Subject: [PATCH, committed] Fortran: NULL pointer dereference in invalid simplification [PR106985] Content-Type: multipart/mixed; boundary=nika-3422f4e6-b9dc-43bd-9f1f-d7c17f4baf59 Date: Tue, 20 Sep 2022 22:35:04 +0200 Importance: normal Sensitivity: Normal X-Priority: 3 X-Provags-ID: V03:K1:CoQVhcd9GX+TOvtyriGFW224ZhSnEjCXwFfXu3ZPGsug9hk0kP+JIdCYxxzWy3kjhjEO+ hSOARi5/wxbxMJ54lfb3sDzX6B4OMoGy0pzKkycp8RzLwdhYTV9Dwqh4SCip1gfurBlfBwe3whJ6 QFeNHgvoRpbx8JOhjGzfaVHsjzOmyprEDujt0JW2i6pshRPahMF9pxktg2ho6lnehw5oFJdoche9 h47wv6//QreubnfrxpuO2g+S40MNqDkUuBDStEErOxKHi/B10CR72Pn1FUrcSJ/hfsj+LvBCmrse Pk= X-UI-Out-Filterresults: notjunk:1;V03:K0:9GhITpxqru4=:i92rHc2zX5umRUlUthitep LP2+MUX4qhfZMkj7LLVrXmaIV9hIDryCLTPnLX/Rm958e8ybSzDkVYWynaE1o4hCAw1+ICkRJ guVbdrEx8hMEM7kL+f0Z7idRTZ8xIw6pf/pf1oHUgXe3WhwQmK/AbIGV4Vz6muMoKVCCb06HP GlnKFmxdomAOtRhtUS4CzHfihiSZQyTAd1gz5gHaOrSfBIQZ/KKxl68P7TjefkEdvYU+5CW7d d9R85HlPbwPwyC5EWVKFuSGS2v8UyvroQ2DSw8s0Pd/Ljf0oCVWd547X1X3HpwGKS8p2ABzEO 1NQGSCw/mscKFgcWiuterxCl2HEUv+jNGS5kMoBnc01wxc1Gjc3cOMdg8OSyXzojh0mQhY0m9 4rMqz6o+YP9Tt8A75e01TLa2lXGMPHXfSbgI6ttk76mY6HKIjhR0hoq2aHHIIta5nP9Qg3sYA BJvtqo57e+8TQcKoFO31TaVGvDBAIiXU5q4nq3bfDjNcm1/VUH2H/04ZtiYz3qU4upys9Q6/9 nSO9qRaX7uUDINi+PCWD+4djnW4E2rrKvGfotk3vhtzZdxFnj57yHgMV7Vhhn0q9KBTRGexoc U3qM6Q0muWmDjkxPuYyIbzIgel7lYEzX7gBRKvSj1BGgiGc4HtXXZYjuuizgof3NGqaojR/4g ID/1YrdXSkpBltLS09Zc9D++Eao0bYBtVDKgusXk/UJhRyo9ieoKvEz9Yv0+R8PR1j/YYP/Xn CK5nb3JTv+A3eTaOOL9hCRlmN9d+Fh5zL/rCuGPfFEbuEl/jq/2I0Asq81epGWyFRKCw0JdPd KzCf2mv X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM,GIT_PATCH_0,KAM_SHORT,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --nika-3422f4e6-b9dc-43bd-9f1f-d7c17f4baf59 Content-Type: text/plain; charset=UTF-8 Dear all, Gerhard found a NULL pointer dereference in a PARAMETER declaration that referenced the same declared parameter. Simple & obvious enough, see attached patch. Regtested on x86_64-pc-linux-gnu, and pushed to mainline: https://gcc.gnu.org/g:8dbb15bc2d019488240c1e69d93121b0347ac092 Thanks, Harald --nika-3422f4e6-b9dc-43bd-9f1f-d7c17f4baf59 Content-Type: text/x-patch Content-Disposition: attachment; filename=pr106985.diff Content-Transfer-Encoding: quoted-printable =46rom 8dbb15bc2d019488240c1e69d93121b0347ac092 Mon Sep 17 00:00:00 2001 From: Harald Anlauf Date: Tue, 20 Sep 2022 22:23:43 +0200 Subject: [PATCH] Fortran: NULL pointer dereference in invalid simplificati= on [PR106985] gcc/fortran/ChangeLog: PR fortran/106985 * expr.cc (gfc_simplify_expr): Avoid NULL pointer dereference. gcc/testsuite/ChangeLog: PR fortran/106985 * gfortran.dg/pr106985.f90: New test. =2D-- gcc/fortran/expr.cc | 3 ++- gcc/testsuite/gfortran.dg/pr106985.f90 | 8 ++++++++ 2 files changed, 10 insertions(+), 1 deletion(-) create mode 100644 gcc/testsuite/gfortran.dg/pr106985.f90 diff --git a/gcc/fortran/expr.cc b/gcc/fortran/expr.cc index be94c18c836..290ddf360c8 100644 =2D-- a/gcc/fortran/expr.cc +++ b/gcc/fortran/expr.cc @@ -2287,7 +2287,8 @@ gfc_simplify_expr (gfc_expr *p, int type) initialization expression, or we want a subsection. */ if (p->symtree->n.sym->attr.flavor =3D=3D FL_PARAMETER && (gfc_init_expr_flag || p->ref - || p->symtree->n.sym->value->expr_type !=3D EXPR_ARRAY)) + || (p->symtree->n.sym->value + && p->symtree->n.sym->value->expr_type !=3D EXPR_ARRAY))) { if (!simplify_parameter_variable (p, type)) return false; diff --git a/gcc/testsuite/gfortran.dg/pr106985.f90 b/gcc/testsuite/gfortr= an.dg/pr106985.f90 new file mode 100644 index 00000000000..f4ed92577a3 =2D-- /dev/null +++ b/gcc/testsuite/gfortran.dg/pr106985.f90 @@ -0,0 +1,8 @@ +! { dg-do compile } +! PR fortran/106985 - ICE in gfc_simplify_expr +! Contributed by G.Steinmetz + +program p + integer, parameter :: a(2) =3D 1 + integer, parameter :: b =3D a(2) + b ! { dg-error "before its definitio= n is complete" } +end =2D- 2.35.3 --nika-3422f4e6-b9dc-43bd-9f1f-d7c17f4baf59--