From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.17.22]) by sourceware.org (Postfix) with ESMTPS id 089543857C52; Sun, 14 Mar 2021 19:54:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 089543857C52 X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [79.232.149.115] ([79.232.149.115]) by web-mail.gmx.net (3c-app-gmx-bap38.server.lan [172.19.172.108]) (via HTTP); Sun, 14 Mar 2021 20:54:41 +0100 MIME-Version: 1.0 Message-ID: From: Harald Anlauf To: Tobias Burnus Cc: Paul Richard Thomas , gcc-patches , fortran Subject: Aw: Re: [PATCH] PR fortran/99112 - [11 Regression] ICE with runtime diagnostics for SIZE intrinsic function Content-Type: text/plain; charset=UTF-8 Date: Sun, 14 Mar 2021 20:54:41 +0100 Importance: normal Sensitivity: Normal In-Reply-To: References: Content-Transfer-Encoding: quoted-printable X-UI-Message-Type: mail X-Priority: 3 X-Provags-ID: V03:K1:F8//7czHOLty+qAciKaa2YEe/nwTD1YgjQRX47Z/OkpP4wT7Psn1aypg1rCjVOdJ9me/Z AEun6GQmQKWYqn7HUDoFhnnXmp8wzeGs04QzeQDv63zHXUt3BOEJ9qDJJSTXiloj2XeojtFRjlCR PrnV3TQShOt4Yrk/KbIev4v8BG+tZ9sL77n+a5xuUIpuY9DAYE/ezWWY+3bgcHYkad7H2WLDGPvj IP3zLU66oZfLf5L0VO2jY5wAUOeJ3JDf1EGKbkndiwk4TwnDf3V0yWpK2WEV2MxD1uKFEA5MNNbs AA= X-UI-Out-Filterresults: notjunk:1;V03:K0:2ijmV41tBQo=:IZ2jOwvR+bMuVUVU4+K4rR Dopr4z8m7GrDA5IJ4El94F3G2DL+haM70IDWY/dfttEeR7kKT98TcvAczA+f651eBiX6AfEq1 SPQLRcXtbXj8n7DNLb7g2m2aqs1D/Ohu0YpJWHUO0mpo78dV1Jceps43y89XK5MMu3iKPXugh B9XTsTQHnMa+0SIjgQl4Jn/S5j4kcalfikPwg+5gDBcVFzmQ+8Sy0nYIwZCsP5RB+8DqKoQBy 0luBC5Tj/S4Xud4/lGB/XLk3EFPXsq+D8HHQQRB3CNNOPLuN03j0csgSr7seFcr/aVZR7V4cg 9F8xm1TzcLgPlAVGeC7cBWi+a4ndk53O3256COTw7dUHlcgUZFqcE87zlldGxOOUvyvG4QKEY JwTVTBbNRUNbixXMERC7o3ZCQlTdVEKzMH4ATpKi8VCIELLluYFz56ZZtqLMbeYDSt8XMxB8V rDkT8j0Q8BWXwzagO3d+Ct5Onixinrimafuefq7weI7FBx+duBS6tfxOMqbk/NspH8e9IYq/V 2QA4m/NuYs2WD1SqZGr7/XiWKHTr8q7VUX9oNm3KdgUOgdaFK+rZLGdlYNJkpa2vuEHkXs37C hfx7tgFW+ERQw= X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FREEMAIL_FROM, KAM_SHORT, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: fortran@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Fortran mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Mar 2021 19:54:47 -0000 Hi Tobias, > I do not see any reason why 'tmp' is replaced by 'temp' in this > code=2E Also for doing patch archeology, it helps if there are no > changes unless it makes sense=2E Adding an -e- does not count ;-) >=20 > Hence, OK with that change=2E I've corrected that=2E This also reduces the size of the patch=2E > Regarding the change: > gfc_conv_intrinsic_size (gfc_se * se, gfc_expr * expr) >=20 > It looks as if the pointer/check is done for > size(dt%foo%bar) > for the 'bar' component' but shouldn't it also be > done for each part ref, if it is a pointer/allocatable? > (i=2Ee=2E 'dt', 'foo' and 'bar'? >=20 > That's independent of the current patch=2E >=20 > Additionally, as there are a lot of special cases for > CLASS =E2=80=93 I wonder whether there also needs to be a special > case for > size(dt%foo%class) > ? >=20 > In particular, the following does ICE for me: This ICEs even without any checks enabled and is now: https://gcc=2Egnu=2Eorg/bugzilla/show_bug=2Ecgi?id=3D99585 > > P=2ES=2E: I couldn't find a Changelog entry that uses co-authors=2E I= s the > > version > > below correct? > =2E=2E=2E > > Co-authored-by: Paul Thomas >=20 > I think you have two options: either the GIT way =E2=80=93 as you did (a= lthough I think the > GIT way usually only has one and not two spaces before the email)=2E >=20 > I did not see it in the commit logs, but it is used in the > testcases for the change-log generator, see: contrib/gcc-changelog/test_= patches=2Etxt I've done it as described above=2E In the git log I see the co-author, wh= ile > git show -1 | =2E/contrib/gcc-changelog/git_check_commit=2Epy -p produces: Checking c2d7c39fcb8a3cb67600cdb6fde49ecb0e951589: OK ------ gcc/fortran/ChangeLog ------=20 2021-03-14 Harald Anlauf Paul Thomas etc=2E Nice! Thanks for the review=2E But as your testcase shows, we're not finished y= et=2E=2E=2E Thanks, Harald