From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.17.20]) by sourceware.org (Postfix) with ESMTPS id 1E4733858D33 for ; Mon, 25 Mar 2024 22:30:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1E4733858D33 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmx.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1E4733858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=212.227.17.20 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711405818; cv=none; b=O3JS+A/hUjSxew0JidUAYNeTY4l4XQdG48p25Q8Flusg7AoTFpbzZmkjn4A9b+drl9K6tkxAoQNQ0chJQ0MeQSQoFpmGYHuVmcW1FfrCBU8Gpiag0wtHLlt53maJQS+h4Dvj6oZLY2PuL1u4hqF/Xb16xQEAup7Dxxq0F86GuSA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711405818; c=relaxed/simple; bh=6wYeKB7zsxs2LovBJHM/yvWRPyuMY6k+pMYGIIh6oAw=; h=DKIM-Signature:MIME-Version:Message-ID:From:To:Subject:Date; b=tn/37e3/bV/51jIRqVWCp5jzEbgLEpYXrS8q302M1PnD/+kw9+d1bTqyoc5zoj9NFuIXwdIgRNnSxnyQ4xprk2Pp4bhZmCzx/wpBG8VazYmvi44XF7oMOuvSsKJG520B1WuDkj3YyhHsldLM2MbJoI+EIYj7aGNcbWllmNguZ5w= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.de; s=s31663417; t=1711405814; x=1712010614; i=anlauf@gmx.de; bh=c04RPpLkMuASnCAe5CavXF7tGb6owKT9agPt81d3g7E=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To: References; b=HLwHezNYg/J1kS4Q+ENzoDhijha/hR4Wz1GCCGnbIQXU3IEuMY8D/+Ig9zAvmEGO uBX7zBHFmdTGxVvUG+5tLd0A+ZJXrB9cNhP5uLw4s42gbVISk1LXpkhFBqihvmOpY lFu6y4avC935sVOpVsTTbvvsw/kYJySHTi7RUjcESYViSXqcVAnBirDBYJVcWf3jx Gopjrg1ApUQgvzDgHgPc3Rsubi2JMWE6LgV6Sh1Y6Uty+4qmFkbvpEzIjXOYvYo87 ZcKqAz3gENcKcEIdBnWev5mKydVzDV2F+dJc5YXkqq3Wdy+UDBdMY163y24BRHVK0 e3iWvnGaE+qSsdfcLA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [79.251.4.107] ([79.251.4.107]) by web-mail.gmx.net (3c-app-gmx-bap03.server.lan [172.19.172.73]) (via HTTP); Mon, 25 Mar 2024 23:30:14 +0100 MIME-Version: 1.0 Message-ID: From: Harald Anlauf To: Jerry D Cc: Manfred Schwarb , fortran Subject: Aw: Re: Invalid "dg-do run" in the testsuite (with 2 blanks) Content-Type: text/plain; charset=UTF-8 Date: Mon, 25 Mar 2024 23:30:14 +0100 Importance: normal Sensitivity: Normal In-Reply-To: References: <9f140118-0327-4d2b-aa07-12508263a1c7@gmail.com> <30b68ddc-3233-4ece-9df8-b2ad93800686@gmail.com> Content-Transfer-Encoding: quoted-printable X-UI-Message-Type: mail X-Priority: 3 X-Provags-ID: V03:K1:FfpTNrwHWDxOlZeG341hW6/xFVz1+r75SpN/iy/jPHo+VZkvvETgxlZZNQR9IOaSyEDtc BkCe7HOC/8MorUVULv15xqPlsRhNzxBzP9zqGu4SNkZp4Am23xdLA9YcTD1s0leJ4y4Sbt6aFyNW g6rRJiLBjP64TGETc97eVL90wBVGrakbNIY9o58st8MT4YmMNHehILPNG2CUC9xMUQfoj4803K4q K618E/4a6XvSl2VCcRGuhY262J8wIYiroQZMQC86PYHrSYuA614iwQ3n2prRCaYTY5C1O1OK7Oi0 p4= UI-OutboundReport: notjunk:1;M01:P0:rLbgkPPl3xg=;vKXPxbMjPz8Md2bqR5SBRk2Tyse kQok6Eq4WN7nwU6fPRCL3MzKfxFo/CnGp9bAkZ3MMZXwIGct1B5iprFZYBh6vT/wN90HdriP8 Qz/cPU55gJFP6YuMjaAMfi98345I9Prj45EKW8Y0xLV1evUi7EnRn/Ju+9VD9vnqBlT7uo1ho kGSL8dcAMGr1t69XwpeYdjsLwaKuhKx95OpGF/xy1RvDrh/ZDOdTgv6Vye/cu9wiuxEyabISi p11OsSjchXC2pDdPb7JB+4/Gh+uxeIRM26NmsGjj63eteXFJP0ixaS+djjJblDY0tZnTFvvfD edCcTdyg3GF9zd+Uz3d8LP7Q0AOmrom5+f7IRRFJt3gDow+4quEXio4k1Sc4hCIdf2TDgmQAt BdN7nB7Z/aZnXS0qxCb1caD2YQd5k06ZSGn3ewNYvJYDtYD0zT5sdP62LOySBShtsVWmbO1jD VgywKXq5OCareEYYEB2gtpm28QibE5rmD8ckF4lnATNE16ew1mXLcj7MEb1r/as4c4rnfQQyV RiHRY0xCecxSuftiL1NWKTQItX+fYc4Q+P/QJeeQ+31JGV+VRlS4lsJLgZ3HQEhS4nprPF23S w8w8tjsfyrcqz4HUnwf1Jvf16mSlV4EDxsd/GwKBSVhsGGXewE7hWf85hJxLlknHsYvOA1yZj XQJGkwMHB9A9SGFx7LhnhiKKyzLMwtn089I7UV/5ZkaFWOrqbOmFUE1HbF32foQ= X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > On 3/25/24 12:53 PM, Harald Anlauf wrote: > >>>>> I noticed by chance that we have quite a lot of improperly specifi= ed do-do > >>>>> directives in the testsuite=2E > >>>>> > >>>>> % grep "dg-do=C2=A0 run" gcc/testsuite/gfortran=2Edg/ -rl|wc -l > >>>>> 83 > >>>>> > >>> > >>> I think this is on purpose=2E > >>> The idea to use a "feature" in dejagnu to only iterate once and not > >>> over all possible options=2E So execution time can be lowered a bit= =2E > >>> > >>> But I don't know if this hack still works, it definitely did work so= me years ago=2E > >>> > >>> Cheers, > >>> Manfred > >=20 > > Is this "feature" documented somewhere? I don't see it on > >=20 > > https://gcc=2Egnu=2Eorg/onlinedocs/gcc-13=2E2=2E0/gccint/Directives=2E= html > >=20 > > Given that the dg-directives are important and possibly fragile, > > and since we had issues in the past, can we check that a test > > that was added works the way intended? > >=20 > >>>>> Note that with two blanks instead of just one a testcase does not = get executed=2E > >>>>> > >>>>> Does anybody want to earn the honors to change the directives and > >>>>> check for "fallout" in the testsuite? > >>>>> > >>>>> Cheers, > >>>>> Harald > >>>>> > >>>> > >>>> One failure after fixing all the spaces ( sed is our friend )=2E > >>>> > >>>> FAIL: gfortran=2Edg/inline_matmul_1=2Ef90=C2=A0=C2=A0 -O0=C2=A0=C2= =A0 scan-tree-dump-times optimized "_gfortran_matmul" 0 > >=20 > > This does actually point to an issue with the testcase: > > it only works properly with optimization enabled=2E > >=20 > > Manual inspection of this test and the expected dump suggests > > that e=2Eg=2E -O1 could have been added to the dg-options directive=2E > >=20 > > Shouldn't we fix at least the dg-options of that testcase? > >=20 > > Cheers, > > Harald > >=20 >=20 > I restored the one test that appeared to fail so that it had the two=20 > spaces 'trick'=2E When run in the test suite, it is compiled with -O=20 > which does invoke the optimization=2E I manually checked the tree dump= =20 > with this option and it indeed has all the _gfortran_matmul calls remove= d=2E >=20 > I am inclined to leave these all untouched with the two spaces in place= =2E >=20 > From the test log: >=20 > PASS: gfortran=2Edg/inline_matmul_1=2Ef90 -O execution test > PASS: gfortran=2Edg/inline_matmul_1=2Ef90 -O scan-tree-dump-times=20 > optimized "_gfortran_matmul" 0 Alright, then leave it that way=2E I find it somewhat unsatisfactory though, to have a behavior of the testsuite harness that is so intranparent=2E If it is a simple oversight that the behavior of double space was never documented, it could simply be fixed, for the sake of everybody=2E The take-home message for me is - whenever I write a testcase that relies on this behavior - to add a comment in the header that this is intended behavior, and set all compiler flags appropriately=2E=2E=2E Cheers, Harald > Regards, >=20 > Jerry >=20 >