From bdd784fc48a283d54f5f1e3cc2a0668c14dd3bee Mon Sep 17 00:00:00 2001 From: Steve Kargl Date: Wed, 16 Nov 2022 22:46:55 +0100 Subject: [PATCH] Fortran: ICE on procedure arguments with non-integer length [PR107707] gcc/fortran/ChangeLog: PR fortran/107707 * interface.cc (gfc_compare_actual_formal): Check that we actually have integer values before asking gmp_* to use them. gcc/testsuite/ChangeLog: PR fortran/107707 * gfortran.dg/pr107707.f90: New test. --- gcc/fortran/interface.cc | 2 ++ gcc/testsuite/gfortran.dg/pr107707.f90 | 13 +++++++++++++ 2 files changed, 15 insertions(+) create mode 100644 gcc/testsuite/gfortran.dg/pr107707.f90 diff --git a/gcc/fortran/interface.cc b/gcc/fortran/interface.cc index 49dbd1d886c..616ae2b1197 100644 --- a/gcc/fortran/interface.cc +++ b/gcc/fortran/interface.cc @@ -3273,9 +3273,11 @@ gfc_compare_actual_formal (gfc_actual_arglist **ap, gfc_formal_arglist *formal, if (a->expr->ts.type == BT_CHARACTER && a->expr->ts.u.cl && a->expr->ts.u.cl->length && a->expr->ts.u.cl->length->expr_type == EXPR_CONSTANT + && a->expr->ts.u.cl->length->ts.type == BT_INTEGER && f->sym->ts.type == BT_CHARACTER && f->sym->ts.u.cl && f->sym->ts.u.cl->length && f->sym->ts.u.cl->length->expr_type == EXPR_CONSTANT + && f->sym->ts.u.cl->length->ts.type == BT_INTEGER && (f->sym->attr.pointer || f->sym->attr.allocatable || (f->sym->as && f->sym->as->type == AS_ASSUMED_SHAPE)) && (mpz_cmp (a->expr->ts.u.cl->length->value.integer, diff --git a/gcc/testsuite/gfortran.dg/pr107707.f90 b/gcc/testsuite/gfortran.dg/pr107707.f90 new file mode 100644 index 00000000000..a8be2b5b299 --- /dev/null +++ b/gcc/testsuite/gfortran.dg/pr107707.f90 @@ -0,0 +1,13 @@ +! { dg-do compile } +! PR fortran/107707 - ICE in gfc_compare_actual_formal +! Contributed by G.Steinmetz + +program p + character(3), allocatable :: c + c = 'abc' + call s(c) +contains + subroutine s(x) + character(real(3)), allocatable :: x ! { dg-error "must be of INTEGER type" } + end +end -- 2.35.3