public inbox for frysk-bugzilla@sourceware.org
help / color / mirror / Atom feed
From: "cagney at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: frysk-bugzilla@sourceware.org
Subject: [Bug general/3721] New: Add ISA <-> Elf map, eliminate switch
Date: Thu, 14 Dec 2006 16:09:00 -0000	[thread overview]
Message-ID: <20061214160929.3721.cagney@redhat.com> (raw)

The file IsaFactory contains:

        ElfEHeader header = elfFile.getEHeader();
        switch (header.machine)
          {
          case ElfEMachine.EM_386:
            {
              if (frysk.core.Build.BUILD_ARCH.equals("i686"))
                return LinuxIa32.isaSingleton ();
              else
                return LinuxIa32On64.isaSingleton();
            }
          case ElfEMachine.EM_PPC:
            {
              // Assume we do not build 32-bit frysk on ppc64.
              if (frysk.core.Build.BUILD_ARCH.equals("powerpc64"))
                return LinuxPPC32On64.isaSingleton ();
              else
                return LinuxPPC.isaSingleton ();
            }
          case ElfEMachine.EM_PPC64:
            return LinuxPPC64.isaSingleton ();
          case ElfEMachine.EM_X86_64:
            return LinuxX8664.isaSingleton ();
          default:
            throw new TaskException("Unknown machine type " + header.machine);
          }

instead the IsaFactory (called ElfIsa????) should contain a hash table mapping
Elf.MACHINE/Elf.ENDIAN/Elf.WORDSIZE <-> a corresponding ISA object and then use
that.

That way, given an ISA, the corresponding Elf info can be found - see fcore; and
given the Elf info the corresponding ISA can be found - see the existing code.

-- 
           Summary: Add ISA <-> Elf map, eliminate switch
           Product: frysk
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: general
        AssignedTo: frysk-bugzilla at sourceware dot org
        ReportedBy: cagney at redhat dot com
                CC: pmuldoon at redhat dot com
OtherBugsDependingO 2234,3387
             nThis:


http://sourceware.org/bugzilla/show_bug.cgi?id=3721

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.


             reply	other threads:[~2006-12-14 16:09 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-14 16:09 cagney at redhat dot com [this message]
2006-12-14 17:20 ` [Bug general/3721] " cagney at redhat dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061214160929.3721.cagney@redhat.com \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=frysk-bugzilla@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).