public inbox for frysk-bugzilla@sourceware.org
help / color / mirror / Atom feed
From: "jan dot kratochvil at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: frysk-bugzilla@sourceware.org
Subject: [Bug general/3763] testObjectFile(lib.elf.tests.TestElf)junit.framework.AssertionFailedError: section-1-alignment expected:<0> but was:<4> on x86_64
Date: Sat, 23 Dec 2006 15:20:00 -0000	[thread overview]
Message-ID: <20061223152032.7666.qmail@sourceware.org> (raw)
In-Reply-To: <20061219125759.3763.mark@klomp.org>


------- Additional Comments From jan dot kratochvil at redhat dot com  2006-12-23 15:20 -------
Created an attachment (id=1470)
 --> (http://sourceware.org/bugzilla/attachment.cgi?id=1470&action=view)
`AC_SYS_LARGEFILE' for whole Frysk as elfutils is using it

This patch should be reviewed by a Frysk architect as I am not sure if this
change really needs to be global.
It is definitely needed for any code sharing ABI with elfutils as elfutils is
already using it.
It is also needed for any code accessing arbitrary files, which can be possibly
larger than 2GB.

Currently the layout:

/* Descriptor for data to be converted to or from memory format.  */
typedef struct
{
  void *d_buf;			/* Pointer to the actual data.	*/
  Elf_Type d_type;		/* Type of this piece of data.	*/
  unsigned int d_version;	/* ELF version.  */
  size_t d_size;		/* Size in bytes.  */
  off_t d_off;			/* Offset into section.  */ 
  size_t d_align;		/* Alignment in section.  */
} Elf_Data;

was handled differently in different parts of Frysk as `off_t' was sometimes
compiled on i686 as 4 bytes and sometimes as 8 bytes, therefore in some cases
`d_align' was fetched from a wrong offset.

After this `AC_SYS_LARGEFILE' fix gets committed the testcase
  frysk-imports$ ./TestRunner lib.elf.tests.TestElf
needs to be updated as currently it expects the buggy value 0 everywhere, there
should be some `expectedDataAlignments' and the alignments should match the
column `Al' of the output of:
  frysk-imports$ readelf -a ./frysk/pkgdatadir/helloworld.o


-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=3763

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.


  parent reply	other threads:[~2006-12-23 15:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-19 12:58 [Bug general/3763] New: " mark at klomp dot org
2006-12-20 13:51 ` [Bug general/3763] " mark at klomp dot org
2006-12-23 15:20 ` jan dot kratochvil at redhat dot com [this message]
2007-01-02  9:38 ` mark at klomp dot org
2007-01-09 14:03 ` jan dot kratochvil at redhat dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061223152032.7666.qmail@sourceware.org \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=frysk-bugzilla@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).