From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <frysk-bugzilla-return-942-listarch-frysk-bugzilla=sourceware.org@sourceware.org>
Received: (qmail 5418 invoked by alias); 15 Jan 2007 19:52:34 -0000
Received: (qmail 5332 invoked by uid 48); 15 Jan 2007 19:52:21 -0000
Date: Mon, 15 Jan 2007 19:52:00 -0000
From: "npremji at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: frysk-bugzilla@sourceware.org
Message-ID: <20070115195220.3873.npremji@redhat.com>
Reply-To: sourceware-bugzilla@sourceware.org
Subject: [Bug general/3873] New: TestLib.isChildOf() to use Stat.ppid rather than proc.getParent().getPid()
X-Bugzilla-Reason: AssignedTo
Mailing-List: contact frysk-bugzilla-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:frysk-bugzilla-subscribe@sourceware.org>
List-Post: <mailto:frysk-bugzilla@sourceware.org>
List-Help: <mailto:frysk-bugzilla-help@sourceware.org>, <http://sourceware.org/lists.html#faqs>
Sender: frysk-bugzilla-owner@sourceware.org
X-SW-Source: 2007-q1/txt/msg00090.txt.bz2
List-Id: <frysk-bugzilla.sourceware.org>

Trying to switch over isChildOf to use Stat.ppid rather than using
proc.getParent().getPid() so that getProc interface can be used (an even more
optimized interface than findProc).

The problem is some testcases have problems with this new implementation as
sometimes the ppid returned from Stat is 0. I think this means that the process
is a zombie but I'm not sure. The Stat.state character returns ^@ instead of 'Z'.

Code:
    static public boolean isChildOf (int pid, Proc proc)
    {
      logger.log(Level.FINE, "isChildOf pid: {0} proc: {1}\n", 
                 new Object[] {new Integer(pid), proc});
	// Process 1 has no parent so can't be a child of mine.
	if (proc.getPid () == 1)
      {
        logger.log(Level.FINE, "isChildOf proc is init\n");
	    return false;
      }
	// If the parent's pid matches this processes pid, assume that
	// is sufficient.  Would need a very very long running system
	// for that to not be the case.        
    
    Stat stat = new Stat();
    stat.refresh(proc.id.id);
    
	if (stat.ppid == pid)
      {
        logger.log(Level.FINE, "isChildOf proc is child\n");
	    return true;
      }
    logger.log(Level.FINE, "isChildOf proc {3} not child pid: {0} ppid: {1}
parent: {2}\n",
               new Object[] {new Integer(pid), new Integer(stat.ppid),
proc.getParent(), proc});
    
    logger.log(Level.FINE, "isChildOf status{0}\n", new Character(stat.state));
	return false;
    }

Log to follow.

-- 
           Summary: TestLib.isChildOf() to use Stat.ppid rather than
                    proc.getParent().getPid()
           Product: frysk
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: general
        AssignedTo: frysk-bugzilla at sourceware dot org
        ReportedBy: npremji at redhat dot com
OtherBugsDependingO 3539
             nThis:


http://sourceware.org/bugzilla/show_bug.cgi?id=3873

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.