public inbox for frysk-bugzilla@sourceware.org help / color / mirror / Atom feed
From: "kris dot van dot hees at oracle dot com" <sourceware-bugzilla@sourceware.org> To: frysk-bugzilla@sourceware.org Subject: [Bug general/4729] New: testLeakyPipes() in TestFileDescriptor trips up junit Date: Tue, 03 Jul 2007 15:36:00 -0000 [thread overview] Message-ID: <20070703153631.4729.kris.van.hees@oracle.com> (raw) The testLeakyPipes() method in TestFileDescriptor executes a loop creating 2000 pipes, followed by a loop to close any file descriptors that are still in existence afterwards (i.e. any that were not garbage collected). Problem is that the creation of pipes is not catching any exceptions that are being thrown by the instantiation of new Pipe objects, thereby resulting in the later code (cleaning up non-garbage collected fds) never being executed. Problems with this: 1) The test never actually tests anything against a PASS/FAIL criterium. Instead, it either passes or its execution is considered an error. That is obviously wrong because tests by their very nature should be defined as testing a PASS/FAIL condition. 2) The test doesn't handle an exception occurring in the lower level code, even though such an exception is not a reflection of a buggy test but rather of a failure criterium being triggered. -- Summary: testLeakyPipes() in TestFileDescriptor trips up junit Product: frysk Version: unspecified Status: NEW Severity: normal Priority: P2 Component: general AssignedTo: frysk-bugzilla at sourceware dot org ReportedBy: kris dot van dot hees at oracle dot com http://sourceware.org/bugzilla/show_bug.cgi?id=4729 ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.
next reply other threads:[~2007-07-03 15:36 UTC|newest] Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top 2007-07-03 15:36 kris dot van dot hees at oracle dot com [this message] 2007-07-03 16:58 ` [Bug general/4729] " cagney at redhat dot com 2008-10-21 21:42 ` cagney at sourceware dot org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20070703153631.4729.kris.van.hees@oracle.com \ --to=sourceware-bugzilla@sourceware.org \ --cc=frysk-bugzilla@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).