From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23894 invoked by alias); 3 Jul 2007 15:36:40 -0000 Received: (qmail 23867 invoked by uid 48); 3 Jul 2007 15:36:31 -0000 Date: Tue, 03 Jul 2007 15:36:00 -0000 From: "kris dot van dot hees at oracle dot com" To: frysk-bugzilla@sourceware.org Message-ID: <20070703153631.4729.kris.van.hees@oracle.com> Reply-To: sourceware-bugzilla@sourceware.org Subject: [Bug general/4729] New: testLeakyPipes() in TestFileDescriptor trips up junit X-Bugzilla-Reason: AssignedTo Mailing-List: contact frysk-bugzilla-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Post: List-Help: , Sender: frysk-bugzilla-owner@sourceware.org X-SW-Source: 2007-q3/txt/msg00010.txt.bz2 List-Id: The testLeakyPipes() method in TestFileDescriptor executes a loop creating 2000 pipes, followed by a loop to close any file descriptors that are still in existence afterwards (i.e. any that were not garbage collected). Problem is that the creation of pipes is not catching any exceptions that are being thrown by the instantiation of new Pipe objects, thereby resulting in the later code (cleaning up non-garbage collected fds) never being executed. Problems with this: 1) The test never actually tests anything against a PASS/FAIL criterium. Instead, it either passes or its execution is considered an error. That is obviously wrong because tests by their very nature should be defined as testing a PASS/FAIL condition. 2) The test doesn't handle an exception occurring in the lower level code, even though such an exception is not a reflection of a buggy test but rather of a failure criterium being triggered. -- Summary: testLeakyPipes() in TestFileDescriptor trips up junit Product: frysk Version: unspecified Status: NEW Severity: normal Priority: P2 Component: general AssignedTo: frysk-bugzilla at sourceware dot org ReportedBy: kris dot van dot hees at oracle dot com http://sourceware.org/bugzilla/show_bug.cgi?id=4729 ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.