[Bug general/4777] fd smash from Elf exception

["pmuldoon at redhat dot com" <sourceware-bugzilla@sourceware.org>]

------- Additional Comments From pmuldoon at redhat dot com  2007-07-12 14:17 -------
The problem is in part the way the Elf object is being used in various parts of
Frysk's code like this:

        try {
            elf = new Elf(proc.getExe(), ElfCommand.ELF_C_READ);
            dwarf = new Dwarf(elf, DwarfCommand.READ, null);
        }
        catch (lib.elf.ElfException ignore) {
            // FIXME: Why is this ignored?
        }

The problem here is two-fold. The elf exception should be caught in it's own
try, not in a composite try block and dealt with. And the code should fail at
that point. Also fd = 0 was a poor choice of an initial value in the Elf's
native code.

The other part if that that Elf object is not valid, yet still allows access to
the native sections. In Java, a constructor is never allowed to return null, so
I suggest we gate further calls with a boolean gate. something like
nativeSuccess = true.


-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=4777

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.