public inbox for frysk-bugzilla@sourceware.org
help / color / mirror / Atom feed
From: "cagney at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: frysk-bugzilla@sourceware.org
Subject: [Bug general/4788] Exe.get() Exceptions are not being thrown
Date: Wed, 18 Jul 2007 02:40:00 -0000 [thread overview]
Message-ID: <20070718023959.23606.qmail@sourceware.org> (raw)
In-Reply-To: <20070712203353.4788.pmuldoon@redhat.com>
------- Additional Comments From cagney at redhat dot com 2007-07-18 02:39 -------
(In reply to comment #4)
> Replaced Exe.get() with standard File.getCanonicalPath():
>
> frysk-core/frysk/proc/live/ChangeLog
> 2007-07-16 Mark Wielaard <mwielaard@redhat.com>
>
> * LinuxProc.java (sendrecExe): Use File.getCanonicalPath().
>
> frysk-imports/frysk/sys/proc/ChangeLog
> 2007-07-16 Mark Wielaard <mwielaard@redhat.com>
>
> * Exe.java: Removed.
> * cni/Exe.cxx: Likewise.
>
> Please report if the problem manifests itself even with this patch applied.
This isn't the problem.
frysk.sys.proc.Exe.get() returns the _contents_ of the link /proc/$$/exe, while
File.getCanonicalPath() attempts to resolve a chain of links, using something
like repeated stat and readlink(2) calls to determine a final path. This leads
to Exe.get() returning strings such as "/bin/bash (deleted)", or occasionally,
what appears to be a corrupt string, while getCanonicalPath will throw an
IOException.
The apparently corrupt string is caused by a kernel "feature" where it is trying
to track the executable as it is renamed. The "feature" can lead to some
strange sequences. vis, how things should work:
$ cp /bin/bash /tmp
$ mkdir /tmp/x
$ /tmp/bash
bash$ mv /tmp/bash /tmp/x
bash$ ls -l /proc/$$/exe
-> /tmp/x/bash
and when something is deleted:
$ cp /bin/bash /tmp
$ /tmp/bash
bash$ rm /tmp/bash
bash$ ls -l /proc/$$/exe
-> /bin/bash (deleted)
how things get confused:
$ cp /bin/bash /tmp
$ cp /bin/bash /tmp/a-really-long-file
$ /bin/bash
bash$ mv /tmp/a-really-long-file /tmp/bash
bash$ ls -l /proc/$$/exe
-> /bin/bash
a dump of the contents of the link shows it in fact contains something like:
/bin/bash^@lly-long-file (deleted)
and this will occur after pre-link as been run.
The existing frysk.sys.proc.Exe was working as designed.
--
http://sourceware.org/bugzilla/show_bug.cgi?id=4788
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
next prev parent reply other threads:[~2007-07-18 2:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-12 20:34 [Bug general/4788] New: " pmuldoon at redhat dot com
2007-07-12 20:43 ` [Bug general/4788] " pmuldoon at redhat dot com
2007-07-12 20:50 ` mark at klomp dot org
2007-07-13 13:23 ` rmoseley at redhat dot com
2007-07-16 10:34 ` mark at klomp dot org
2007-07-18 2:40 ` cagney at redhat dot com [this message]
2007-07-18 8:15 ` mark at klomp dot org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070718023959.23606.qmail@sourceware.org \
--to=sourceware-bugzilla@sourceware.org \
--cc=frysk-bugzilla@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).