From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <frysk-bugzilla-return-2341-listarch-frysk-bugzilla=sourceware.org@sourceware.org>
Received: (qmail 22382 invoked by alias); 27 Jul 2007 09:38:33 -0000
Received: (qmail 22357 invoked by uid 48); 27 Jul 2007 09:38:18 -0000
Date: Fri, 27 Jul 2007 09:38:00 -0000
From: "mark at klomp dot org" <sourceware-bugzilla@sourceware.org>
To: frysk-bugzilla@sourceware.org
Message-ID: <20070727093818.4852.mark@klomp.org>
Reply-To: sourceware-bugzilla@sourceware.org
Subject: [Bug general/4852] New: Never use Proc.getExe() except for display (possible) executable path
X-Bugzilla-Reason: AssignedTo
Mailing-List: contact frysk-bugzilla-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:frysk-bugzilla-subscribe@sourceware.org>
List-Post: <mailto:frysk-bugzilla@sourceware.org>
List-Help: <mailto:frysk-bugzilla-help@sourceware.org>, <http://sourceware.org/lists.html#faqs>
Sender: frysk-bugzilla-owner@sourceware.org
X-SW-Source: 2007-q3/txt/msg00176.txt.bz2
List-Id: <frysk-bugzilla.sourceware.org>

Proc.getExe() returns a path to the (possibly incorrect) of the executable being
examined. Since it isn't guaranteed to be correct it should never be used for
anything except for informational messages. Since it is often correct it is used
in places in frysk-core to get at the executable, this is not correct though
(for example when examining a core file it is not the executable you are
interested in, but the data/text/code collected by the CoreFile reader). In
particular these files should be examined and changed that create Elf objects
directly from the Proc.getExe() result:

frysk-core/frysk/debuginfo/DebugInfo.java
frysk-core/frysk/proc/TestTaskObserverCode.java
frysk-core/frysk/proc/dead/TestLinuxCore.java

frysk-core/frysk/dom/DOMImage.java uses getExe() to get at the include paths for
the source.

frysk-core/frysk/proc/IsaFactory.java getIsa() reads /proc/pid/exe directly.

frysk-gui also uses getExe() repeatably, but probably correctly, these should be
checked though:

frysk-gui/frysk/gui/sessions/WatchList.java
frysk-gui/frysk/gui/monitor/GuiProc.java
frysk-gui/frysk/gui/monitor/PickProcListView.java
frysk-gui/frysk/gui/monitor/PickProcsListView.java
frysk-gui/frysk/gui/monitor/filters/ProcPathFilter.java
frysk-gui/frysk/gui/monitor/PickProcDialog.java
frysk-gui/frysk/gui/srcwin/SourceWindow.java

-- 
           Summary: Never use Proc.getExe() except for display (possible)
                    executable path
           Product: frysk
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: general
        AssignedTo: frysk-bugzilla at sourceware dot org
        ReportedBy: mark at klomp dot org


http://sourceware.org/bugzilla/show_bug.cgi?id=4852

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.