public inbox for frysk-bugzilla@sourceware.org help / color / mirror / Atom feed
From: "mark at klomp dot org" <sourceware-bugzilla@sourceware.org> To: frysk-bugzilla@sourceware.org Subject: [Bug general/5740] break m<TAB> causes an NPE Date: Wed, 06 Feb 2008 13:24:00 -0000 [thread overview] Message-ID: <20080206132354.9378.qmail@sourceware.org> (raw) In-Reply-To: <20080206131239.5740.pmuldoon@redhat.com> ------- Additional Comments From mark at klomp dot org 2008-02-06 13:23 ------- This comes from not checking whether the compilation unit for the current address actually exists. Quick and dirty patch that seems to work around the issue. The XXX in the comments suggest this is code isn't finished though. diff --git a/frysk-core/frysk/debuginfo/ObjectDeclarationSearchEngine.java b/fry index 94aee90..86e8e1b 100644 --- a/frysk-core/frysk/debuginfo/ObjectDeclarationSearchEngine.java +++ b/frysk-core/frysk/debuginfo/ObjectDeclarationSearchEngine.java @@ -139,16 +139,18 @@ public class ObjectDeclarationSearchEngine implements Expr /** * XXX: Who knows if this works; it is certainly not implemented * correctly as it should use the ObjectDeclaration. */ public void complete(String incomplete, List candidates) { long pc = frame.getAdjustedAddress(); Dwfl dwfl = DwflCache.getDwfl(frame.getTask()); DwflDieBias bias = dwfl.getCompilationUnit(pc); + if (bias == null) + return; DwarfDie die = bias.die; DwarfDie[] allDies = die.getScopes(pc - bias.bias); List candidates_p = die.getScopeVarNames(allDies, incomplete); for (Iterator i = candidates_p.iterator(); i.hasNext();) { String sNext = (String) i.next(); candidates.add(sNext); } } -- http://sourceware.org/bugzilla/show_bug.cgi?id=5740 ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee.
prev parent reply other threads:[~2008-02-06 13:24 UTC|newest] Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top 2008-02-06 13:13 [Bug general/5740] New: " pmuldoon at redhat dot com 2008-02-06 13:24 ` mark at klomp dot org [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20080206132354.9378.qmail@sourceware.org \ --to=sourceware-bugzilla@sourceware.org \ --cc=frysk-bugzilla@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).