public inbox for frysk-bugzilla@sourceware.org
help / color / mirror / Atom feed
From: "swagiaal at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: frysk-bugzilla@sourceware.org
Subject: [Bug general/5730] stack trace does not show location information
Date: Wed, 06 Feb 2008 18:29:00 -0000	[thread overview]
Message-ID: <20080206182909.9001.qmail@sourceware.org> (raw)
In-Reply-To: <20080205201316.5730.tromey@redhat.com>


------- Additional Comments From swagiaal at redhat dot com  2008-02-06 18:29 -------
looks like this was broken by this commit:
     bbf660ad5f803e000274503ad878040f4d604fef

I am still running git bisect to prove it

patch snippit:
@@ -92,13 +91,7 @@ class LibunwindFrame extends Frame
      * Returns the current program counter of this Frame.
      */
     public long getAddress() {
-	ProcInfo myInfo = cursor.getProcInfo();
-	ProcName myName = cursor.getProcName(0);
-    
-	if (myInfo.getError() != 0 || myName.getError() != 0)
-	    return 0;
-    
-	return myInfo.getStartIP() + myName.getOffset();
+      return cursor.getIP();
     }

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mwielaard at redhat dot com


http://sourceware.org/bugzilla/show_bug.cgi?id=5730

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.


  parent reply	other threads:[~2008-02-06 18:29 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-05 20:13 [Bug general/5730] New: " tromey at redhat dot com
2008-02-05 20:50 ` [Bug general/5730] " swagiaal at redhat dot com
2008-02-05 20:51 ` swagiaal at redhat dot com
2008-02-06 18:29 ` swagiaal at redhat dot com [this message]
2008-02-06 18:59 ` mark at klomp dot org
2008-02-06 20:20 ` swagiaal at redhat dot com
2008-03-05  3:04 ` scox at redhat dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080206182909.9001.qmail@sourceware.org \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=frysk-bugzilla@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).