[Bug general/6600] New: dwfl_module_getsrc doesn't allow for bias

[Bug general/6600] New: dwfl_module_getsrc doesn't allow for bias

[cagney at redhat dot com]

(unless of course the caller is expected to)

@@ -56,18 +57,24 @@ dwfl_module_getsrc (Dwfl_Module *mod, Dwarf_Addr addr)
   Dwarf_Addr bias;
   if (INTUSE(dwfl_module_getdwarf) (mod, &bias) == NULL)
     return NULL;
+  fprintf(stderr, "got dwarf 0x%lx\n", addr);
 
   struct dwfl_cu *cu;
   Dwfl_Error error = __libdwfl_addrcu (mod, addr, &cu);
   if (likely (error == DWFL_E_NOERROR))
     error = __libdwfl_cu_getsrclines (cu);
+  fprintf(stderr, "got addrcu\n");
   if (likely (error == DWFL_E_NOERROR))
     {
+      addr = addr - bias;
+      fprintf(stderr, "searching unbiased 0x%lx\n", (long) addr);
       /* The lines are sorted by address, so we can use binary search.  */
       size_t l = 0, u = cu->die.cu->lines->nlines;
       while (l < u)
        {
          size_t idx = (l + u) / 2;
+         fprintf(stderr, "%d 0x%lx\n", (int)idx,
+                 (long) cu->die.cu->lines->info[idx].addr);
          if (addr < cu->die.cu->lines->info[idx].addr)
            u = idx;
          else if (addr > cu->die.cu->lines->info[idx].addr)

which gives the improved effect:

got dwarf 0x2aaab057683c
addrarange 2aaab057683c
naranges 859
adjusted 6e83c by bias 2aaab0508000
found arange at 624
got addrcu
searching unbiased 0x6e83c
73 0x6e950
36 0x57fba
55 0x6e87b
46 0x6e83c

-- 
           Summary: dwfl_module_getsrc doesn't allow for bias
           Product: frysk
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: general
        AssignedTo: frysk-bugzilla at sourceware dot org
        ReportedBy: cagney at redhat dot com
OtherBugsDependingO 2785
             nThis:


http://sourceware.org/bugzilla/show_bug.cgi?id=6600

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug general/6600] dwfl_module_getsrc doesn't allow for bias

[cagney at redhat dot com]

------- Additional Comments From cagney at redhat dot com  2008-06-06 00:48 -------
upstream: https://bugzilla.redhat.com/show_bug.cgi?id=450229

-- 


http://sourceware.org/bugzilla/show_bug.cgi?id=6600

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug general/6600] dwfl_module_getsrc doesn't allow for bias

[cagney at redhat dot com]

-- 
           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|frysk-bugzilla at sourceware|cagney at redhat dot com
                   |dot org                     |
             Status|NEW                         |ASSIGNED


http://sourceware.org/bugzilla/show_bug.cgi?id=6600

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.