public inbox for frysk-bugzilla@sourceware.org
help / color / mirror / Atom feed
* [Bug general/4729] New: testLeakyPipes() in TestFileDescriptor trips up junit
@ 2007-07-03 15:36 kris dot van dot hees at oracle dot com
2007-07-03 16:58 ` [Bug general/4729] " cagney at redhat dot com
2008-10-21 21:42 ` cagney at sourceware dot org
0 siblings, 2 replies; 3+ messages in thread
From: kris dot van dot hees at oracle dot com @ 2007-07-03 15:36 UTC (permalink / raw)
To: frysk-bugzilla
The testLeakyPipes() method in TestFileDescriptor executes a loop creating 2000
pipes, followed by a loop to close any file descriptors that are still in
existence afterwards (i.e. any that were not garbage collected).
Problem is that the creation of pipes is not catching any exceptions that are
being thrown by the instantiation of new Pipe objects, thereby resulting in the
later code (cleaning up non-garbage collected fds) never being executed.
Problems with this:
1) The test never actually tests anything against a PASS/FAIL criterium.
Instead, it either passes or its execution is considered an error. That
is obviously wrong because tests by their very nature should be defined as
testing a PASS/FAIL condition.
2) The test doesn't handle an exception occurring in the lower level code, even
though such an exception is not a reflection of a buggy test but rather of
a failure criterium being triggered.
--
Summary: testLeakyPipes() in TestFileDescriptor trips up junit
Product: frysk
Version: unspecified
Status: NEW
Severity: normal
Priority: P2
Component: general
AssignedTo: frysk-bugzilla at sourceware dot org
ReportedBy: kris dot van dot hees at oracle dot com
http://sourceware.org/bugzilla/show_bug.cgi?id=4729
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Bug general/4729] testLeakyPipes() in TestFileDescriptor trips up junit
2007-07-03 15:36 [Bug general/4729] New: testLeakyPipes() in TestFileDescriptor trips up junit kris dot van dot hees at oracle dot com
@ 2007-07-03 16:58 ` cagney at redhat dot com
2008-10-21 21:42 ` cagney at sourceware dot org
1 sibling, 0 replies; 3+ messages in thread
From: cagney at redhat dot com @ 2007-07-03 16:58 UTC (permalink / raw)
To: frysk-bugzilla
--
What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|frysk-bugzilla at sourceware|cagney at redhat dot com
|dot org |
Status|NEW |ASSIGNED
http://sourceware.org/bugzilla/show_bug.cgi?id=4729
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Bug general/4729] testLeakyPipes() in TestFileDescriptor trips up junit
2007-07-03 15:36 [Bug general/4729] New: testLeakyPipes() in TestFileDescriptor trips up junit kris dot van dot hees at oracle dot com
2007-07-03 16:58 ` [Bug general/4729] " cagney at redhat dot com
@ 2008-10-21 21:42 ` cagney at sourceware dot org
1 sibling, 0 replies; 3+ messages in thread
From: cagney at sourceware dot org @ 2008-10-21 21:42 UTC (permalink / raw)
To: frysk-bugzilla
--
What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|cagney at redhat dot com |frysk-bugzilla at sourceware
| |dot org
Status|REOPENED |NEW
http://sourceware.org/bugzilla/show_bug.cgi?id=4729
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-10-21 21:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-07-03 15:36 [Bug general/4729] New: testLeakyPipes() in TestFileDescriptor trips up junit kris dot van dot hees at oracle dot com
2007-07-03 16:58 ` [Bug general/4729] " cagney at redhat dot com
2008-10-21 21:42 ` cagney at sourceware dot org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).