public inbox for frysk-cvs@sourceware.org
help / color / mirror / Atom feed
From: rmoseley@sourceware.org
To: frysk-cvs@sourceware.org
Subject: [SCM]  master: Fix a couple of problems with procs terminating before frysk knows it.
Date: Mon, 14 Jan 2008 20:03:00 -0000	[thread overview]
Message-ID: <20080114200253.6577.qmail@sourceware.org> (raw)

The branch, master has been updated
       via  5f9911f885000327e51a4a5269ec3d1d3c42e3c4 (commit)
      from  e89a4ee2697f66d023e8cb11b8e069e5f0c1e2ee (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email.

- Log -----------------------------------------------------------------
commit 5f9911f885000327e51a4a5269ec3d1d3c42e3c4
Author: Rick Moseley <rmoseley@localhost.localdomain>
Date:   Mon Jan 14 14:02:16 2008 -0600

    Fix a couple of problems with procs terminating before frysk knows it.
    
    * LinuxPtraceTask.java: Catch errors from Ptrace.detach().
    * Proc.java: Remove requestAbandon() from requestKill().

-----------------------------------------------------------------------

Summary of changes:
 frysk-core/frysk/proc/ChangeLog                 |    4 ++++
 frysk-core/frysk/proc/Proc.java                 |    1 -
 frysk-core/frysk/proc/live/ChangeLog            |    4 ++++
 frysk-core/frysk/proc/live/LinuxPtraceTask.java |    7 ++++++-
 4 files changed, 14 insertions(+), 2 deletions(-)

First 500 lines of diff:
diff --git a/frysk-core/frysk/proc/ChangeLog b/frysk-core/frysk/proc/ChangeLog
index e3b5554..425bd8b 100644
--- a/frysk-core/frysk/proc/ChangeLog
+++ b/frysk-core/frysk/proc/ChangeLog
@@ -1,3 +1,7 @@
+2008-01-14  Rick Moseley  <rmoseley@redhat.com>
+
+	* Proc.java: Remove requestAbandon() from requestKill().
+
 2008-01-11  Andrew Cagney  <cagney@redhat.com>
 
 	* Task.java (getEntryPointAddress()): Delete.
diff --git a/frysk-core/frysk/proc/Proc.java b/frysk-core/frysk/proc/Proc.java
index c082155..d2ac547 100644
--- a/frysk-core/frysk/proc/Proc.java
+++ b/frysk-core/frysk/proc/Proc.java
@@ -208,7 +208,6 @@ public abstract class Proc {
 		    quitLatch.countDown();
 		}
 	    });
-	this.requestAbandon();
     }
 
     /**
diff --git a/frysk-core/frysk/proc/live/ChangeLog b/frysk-core/frysk/proc/live/ChangeLog
index 3d07a50..36ec797 100644
--- a/frysk-core/frysk/proc/live/ChangeLog
+++ b/frysk-core/frysk/proc/live/ChangeLog
@@ -1,3 +1,7 @@
+2008-01-14  Rick Moseley  <rmoseley@redhat.com>
+
+	* LinuxPtraceTask.java: Catch errors from Ptrace.detach().
+
 2008-01-14  Phil Muldoon  <pmuldoon@redhat.com>
 
 	* LinuxPtraceProc.java (getMaps): Remove if maps == null.
diff --git a/frysk-core/frysk/proc/live/LinuxPtraceTask.java b/frysk-core/frysk/proc/live/LinuxPtraceTask.java
index 36ef26c..2afb38d 100644
--- a/frysk-core/frysk/proc/live/LinuxPtraceTask.java
+++ b/frysk-core/frysk/proc/live/LinuxPtraceTask.java
@@ -357,7 +357,12 @@ public class LinuxPtraceTask extends LiveTask {
     public void sendDetach (int sig)
     {
 	logger.log(Level.FINE, "{0} sendDetach\n", this);
-	Ptrace.detach(getTid(), sig);
+	// Ignore problems trying to detach, most of the time the problem is the
+	// process has already left the cpu queue
+	try {
+	    Ptrace.detach(getTid(), sig);
+	} catch (Exception e) {
+	}
     }
 
     public void startTracingSyscalls ()


hooks/post-receive
--
frysk system monitor/debugger


                 reply	other threads:[~2008-01-14 20:03 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080114200253.6577.qmail@sourceware.org \
    --to=rmoseley@sourceware.org \
    --cc=frysk-cvs@sourceware.org \
    --cc=frysk@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).