public inbox for frysk-cvs@sourceware.org
help / color / mirror / Atom feed
From: pmuldoon@sourceware.org
To: frysk-cvs@sourceware.org
Subject: [SCM]  master: Merge branch 'master' of ssh://sources.redhat.com/git/frysk
Date: Tue, 26 Feb 2008 15:32:00 -0000	[thread overview]
Message-ID: <20080226153253.15861.qmail@sourceware.org> (raw)

The branch, master has been updated
       via  1f00d0320e752d60da44436f1a0612a64123702a (commit)
       via  829dda048d5c206a84e4ce1e73de1efb14f2ea67 (commit)
      from  7174ba407d72d790645f20a5db9682dd142bd772 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email.

- Log -----------------------------------------------------------------
commit 1f00d0320e752d60da44436f1a0612a64123702a
Merge: 829dda048d5c206a84e4ce1e73de1efb14f2ea67 7174ba407d72d790645f20a5db9682dd142bd772
Author: Phil Muldoon <pmuldoon@ups.hsv.redhat.com>
Date:   Tue Feb 26 09:32:17 2008 -0600

    Merge branch 'master' of ssh://sources.redhat.com/git/frysk

commit 829dda048d5c206a84e4ce1e73de1efb14f2ea67
Author: Phil Muldoon <pmuldoon@ups.hsv.redhat.com>
Date:   Tue Feb 26 09:31:37 2008 -0600

    2008-02-26  Phil Muldoon  <pmuldoon@redhat.com>
    
            * CorefileBytebuffer.java (peek): Account for segments
            that are neither in the corefile, or backing solib/exe.

-----------------------------------------------------------------------

Summary of changes:
 frysk-core/frysk/proc/dead/ChangeLog               |    5 ++++
 frysk-core/frysk/proc/dead/CorefileByteBuffer.java |   21 +++++++++++++------
 2 files changed, 19 insertions(+), 7 deletions(-)

First 500 lines of diff:
diff --git a/frysk-core/frysk/proc/dead/ChangeLog b/frysk-core/frysk/proc/dead/ChangeLog
index f09f868..ac109e9 100644
--- a/frysk-core/frysk/proc/dead/ChangeLog
+++ b/frysk-core/frysk/proc/dead/ChangeLog
@@ -1,3 +1,8 @@
+2008-02-26  Phil Muldoon  <pmuldoon@redhat.com>
+
+	* CorefileBytebuffer.java (peek): Account for segments
+	that are neither in the corefile, or backing solib/exe.
+
 2008-02-25  Andrew Cagney  <cagney@redhat.com>
 
 	* LinuxExeFactory.java: New.  Merge in LinuxExeHost, LinuxExeProc,
diff --git a/frysk-core/frysk/proc/dead/CorefileByteBuffer.java b/frysk-core/frysk/proc/dead/CorefileByteBuffer.java
index f4cb123..63dd0c2 100644
--- a/frysk-core/frysk/proc/dead/CorefileByteBuffer.java
+++ b/frysk-core/frysk/proc/dead/CorefileByteBuffer.java
@@ -100,22 +100,29 @@ public class CorefileByteBuffer extends ByteBuffer {
   {
 
 
+    finest.log(this,"peek() at 0x",address);
     byte[] buffer = new byte[1];
     MapAddressHeader metaLine = findMetaData(address);
 
     if (metaLine != null)
-      if (checkCorefileAddress(metaLine))
-	{
+      if (checkCorefileAddress(metaLine)) {
 	  long offset = convertAddressToOffset(address);
 	  this.coreFileRaw.pread(offset, buffer,0,1);
 	}
       else
 	{
-	  if (!metaLine.name.equals(""))
-	    {
-	      StatelessFile temp = new StatelessFile(new File(metaLine.name));
-	      long offset = metaLine.solibOffset  + (address - metaLine.vaddr);
-	      temp.pread(offset, buffer,0,1);
+	  if (!metaLine.name.equals("")) {
+	        finest.log(this,"Attempting to read from non-corefile: ", metaLine.name);
+		File fileCheck = new File(metaLine.name);
+		if (((fileCheck.exists()) && fileCheck.canRead())) {
+		    StatelessFile temp = new StatelessFile(new File(metaLine.name));	      
+		    long offset = metaLine.solibOffset  + (address - metaLine.vaddr);
+		    temp.pread(offset, buffer,0,1);
+		} else {
+		    throw new RuntimeException("CorefileByteBuffer: Cannot peek() at address 0x"+
+					       Long.toHexString(address)+". Offset exists in file: " +
+					       metaLine.name+" but that file cannot be accessed.");
+		}
 	    }
 	}
 	


hooks/post-receive
--
frysk system monitor/debugger


             reply	other threads:[~2008-02-26 15:32 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-26 15:32 pmuldoon [this message]
  -- strict thread matches above, loose matches on Subject: below --
2008-06-05 15:33 rmoseley
2008-05-12 16:30 rmoseley
2008-05-12 16:07 pmuldoon
2008-05-09 17:29 rmoseley
2008-04-02 22:41 pmuldoon
2008-04-01 12:28 pmuldoon
2008-03-20 20:20 rmoseley
2008-03-18 16:22 pmuldoon
2008-01-24 19:23 rmoseley
2008-01-23 21:10 rmoseley
2008-01-03 16:55 pmuldoon
2007-12-13 20:18 rmoseley
2007-12-04 17:45 jflavio
2007-11-30  4:24 jflavio
2007-11-28 21:40 jflavio
2007-11-28 16:20 jflavio
2007-11-28 13:08 pmuldoon
2007-11-28 12:04 mark
2007-11-20 22:47 scox
2007-11-19 17:58 scox
2007-11-17  8:35 rmoseley
2007-11-16 15:59 scox
2007-11-16 14:59 pmuldoon
2007-11-14  2:38 scox
2007-11-14  2:09 jflavio
2007-11-13  0:41 scox
2007-11-10 14:47 jflavio
2007-11-10  0:34 scox
2007-11-09 14:59 jflavio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080226153253.15861.qmail@sourceware.org \
    --to=pmuldoon@sourceware.org \
    --cc=frysk-cvs@sourceware.org \
    --cc=frysk@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).