public inbox for frysk-cvs@sourceware.org help / color / mirror / Atom feed
From: cagney@sourceware.org To: frysk-cvs@sourceware.org Subject: [SCM] master: Delete fstack.parseCoresFIXME. Date: Wed, 27 Feb 2008 03:21:00 -0000 [thread overview] Message-ID: <20080227032137.15296.qmail@sourceware.org> (raw) The branch, master has been updated via 79569bf5e4b48be2efebcea902795514f238ca9f (commit) from 13eaab0224ce71fe031becc059a0d342b6047a4e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email. - Log ----------------------------------------------------------------- commit 79569bf5e4b48be2efebcea902795514f238ca9f Author: Andrew Cagney <cagney@redhat.com> Date: Tue Feb 26 22:20:25 2008 -0500 Delete fstack.parseCoresFIXME. frysk-core/frysk/bindir/ChangeLog 2008-02-26 Andrew Cagney <cagney@redhat.com> * fstack.java (parseCores(Proc[])): Replace parseCoresFIXME. (stackCore(Proc)): Replace stackCore(CoreExePair). frysk-core/frysk/util/ChangeLog 2008-02-26 Andrew Cagney <cagney@redhat.com> * Util.java (getProcFromCoreExePair(CoreExePair)): Delete. ----------------------------------------------------------------------- Summary of changes: frysk-core/frysk/bindir/ChangeLog | 3 ++ frysk-core/frysk/bindir/fstack.java | 41 ++++++++++++++-------------------- frysk-core/frysk/util/ChangeLog | 2 + frysk-core/frysk/util/Util.java | 7 ------ 4 files changed, 22 insertions(+), 31 deletions(-) First 500 lines of diff: diff --git a/frysk-core/frysk/bindir/ChangeLog b/frysk-core/frysk/bindir/ChangeLog index 506f506..340a72c 100644 --- a/frysk-core/frysk/bindir/ChangeLog +++ b/frysk-core/frysk/bindir/ChangeLog @@ -1,5 +1,8 @@ 2008-02-26 Andrew Cagney <cagney@redhat.com> + * fstack.java (parseCores(Proc[])): Replace parseCoresFIXME. + (stackCore(Proc)): Replace stackCore(CoreExePair). + * fauxv.java: Update to match ProcEvent. * fmaps.java: Ditto. * fexe.java: Ditto. diff --git a/frysk-core/frysk/bindir/fstack.java b/frysk-core/frysk/bindir/fstack.java index b25b682..0424525 100644 --- a/frysk-core/frysk/bindir/fstack.java +++ b/frysk-core/frysk/bindir/fstack.java @@ -50,9 +50,7 @@ import frysk.proc.Proc; import frysk.proc.ProcBlockAction; import frysk.proc.ProcCoreAction; import frysk.util.CommandlineParser; -import frysk.util.CoreExePair; import frysk.util.StacktraceAction; -import frysk.util.Util; import gnu.classpath.tools.getopt.Option; import gnu.classpath.tools.getopt.OptionException; @@ -136,14 +134,11 @@ public final class fstack } } - private static void stackCore(CoreExePair coreExePair) - { - - Proc proc = Util.getProcFromCoreExePair(coreExePair); - stacker = new Stacker(printWriter, proc, new PrintEvent(), numberOfFrames, elfOnly,virtualFrames,printParameters,printScopes, fullpath); - new ProcCoreAction(proc, stacker); - Manager.eventLoop.run(); - } + private static void stackCore(Proc proc) { + stacker = new Stacker(printWriter, proc, new PrintEvent(), numberOfFrames, elfOnly,virtualFrames,printParameters,printScopes, fullpath); + new ProcCoreAction(proc, stacker); + Manager.eventLoop.run(); + } private static void stackPid(Proc proc) { stacker = new Stacker(printWriter, proc, new AbandonPrintEvent(proc), numberOfFrames, elfOnly,virtualFrames,printParameters,printScopes, fullpath); @@ -154,20 +149,18 @@ public final class fstack public static void main (String[] args) { - parser = new CommandlineParser("fstack") - { - //@Override - public void parseCoresFIXME(CoreExePair[] coreExePairs) { - for (int i = 0; i < coreExePairs.length; i++) - stackCore(coreExePairs[i]); - } - - //@Override - public void parsePids(Proc[] procs) { - for (int i = 0; i < procs.length; i++) - stackPid(procs[i]); - } - }; + parser = new CommandlineParser("fstack") { + //@Override + public void parseCores(Proc[] cores) { + for (int i = 0; i < cores.length; i++) + stackCore(cores[i]); + } + //@Override + public void parsePids(Proc[] procs) { + for (int i = 0; i < procs.length; i++) + stackPid(procs[i]); + } + }; parser.add(new Option("number-of-frames", 'n', "number of frames to print. Use -n 0 or" + " -n all to print all frames.", "<number of frames>") { diff --git a/frysk-core/frysk/util/ChangeLog b/frysk-core/frysk/util/ChangeLog index b129829..fbe5f51 100644 --- a/frysk-core/frysk/util/ChangeLog +++ b/frysk-core/frysk/util/ChangeLog @@ -1,5 +1,7 @@ 2008-02-26 Andrew Cagney <cagney@redhat.com> + * Util.java (getProcFromCoreExePair(CoreExePair)): Delete. + * CommandlineParser.java: Add logging; check for null getMessage(). diff --git a/frysk-core/frysk/util/Util.java b/frysk-core/frysk/util/Util.java index 0bcce53..f3c1de3 100644 --- a/frysk-core/frysk/util/Util.java +++ b/frysk-core/frysk/util/Util.java @@ -70,13 +70,6 @@ public class Util return proc; } - public static Proc getProcFromCoreExePair(CoreExePair coreExePair) { - if (coreExePair.exeFile == null) - return getProcFromCoreFile(coreExePair.coreFile); - else - return getProcFromCoreFile(coreExePair.coreFile, coreExePair.exeFile); - } - /** * Return a Proc associated with the given pid. * @param procId The given pid. hooks/post-receive -- frysk system monitor/debugger
reply other threads:[~2008-02-27 3:21 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20080227032137.15296.qmail@sourceware.org \ --to=cagney@sourceware.org \ --cc=frysk-cvs@sourceware.org \ --cc=frysk@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).