public inbox for frysk-cvs@sourceware.org
help / color / mirror / Atom feed
From: cagney@sourceware.org
To: frysk-cvs@sourceware.org
Subject: [SCM] master: Reduce scope of Task.getTaskId().
Date: Wed, 27 Feb 2008 18:12:00 -0000 [thread overview]
Message-ID: <20080227181240.20830.qmail@sourceware.org> (raw)
The branch, master has been updated
via d0389c68ba9e11e6ffacec53596d2b05425f1c4b (commit)
from b7b5cd5297f20f4946c1913a45bfddcb837cbf00 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email.
- Log -----------------------------------------------------------------
commit d0389c68ba9e11e6ffacec53596d2b05425f1c4b
Author: Andrew Cagney <cagney@redhat.com>
Date: Wed Feb 27 13:08:40 2008 -0500
Reduce scope of Task.getTaskId().
frysk-core/frysk/proc/ChangeLog
2008-02-27 Andrew Cagney <cagney@redhat.com>
* Task.java (getTaskId()): Make package private.
* TestTaskSyscallObserver.java: Use Task.getTid().
frysk-core/frysk/proc/dead/ChangeLog
2008-02-27 Andrew Cagney <cagney@redhat.com>
* TestLinuxCore.java: Do not use Task.getTaskId.
-----------------------------------------------------------------------
Summary of changes:
frysk-core/frysk/proc/ChangeLog | 3 +
frysk-core/frysk/proc/Task.java | 2 +-
frysk-core/frysk/proc/TestTaskSyscallObserver.java | 44 ++++++++++----------
frysk-core/frysk/proc/dead/ChangeLog | 2 +
frysk-core/frysk/proc/dead/TestLinuxCore.java | 1 -
5 files changed, 28 insertions(+), 24 deletions(-)
First 500 lines of diff:
diff --git a/frysk-core/frysk/proc/ChangeLog b/frysk-core/frysk/proc/ChangeLog
index 80ffe82..3412eb1 100644
--- a/frysk-core/frysk/proc/ChangeLog
+++ b/frysk-core/frysk/proc/ChangeLog
@@ -1,5 +1,8 @@
2008-02-27 Andrew Cagney <cagney@redhat.com>
+ * Task.java (getTaskId()): Make package private.
+ * TestTaskSyscallObserver.java: Use Task.getTid().
+
* Proc.java (remove(Task)): Make protected.
2008-02-26 Andrew Cagney <cagney@redhat.com>
diff --git a/frysk-core/frysk/proc/Task.java b/frysk-core/frysk/proc/Task.java
index d42fe74..99d6474 100644
--- a/frysk-core/frysk/proc/Task.java
+++ b/frysk-core/frysk/proc/Task.java
@@ -68,7 +68,7 @@ public abstract class Task {
/**
* Return the task's corresponding TaskId.
*/
- public final TaskId getTaskId() {
+ TaskId getTaskId() {
return id;
}
private final TaskId id;
diff --git a/frysk-core/frysk/proc/TestTaskSyscallObserver.java b/frysk-core/frysk/proc/TestTaskSyscallObserver.java
index 7f6250e..1c8e5c4 100644
--- a/frysk-core/frysk/proc/TestTaskSyscallObserver.java
+++ b/frysk-core/frysk/proc/TestTaskSyscallObserver.java
@@ -548,28 +548,28 @@ public class TestTaskSyscallObserver
}
}
- TestSyscallInterruptXXX(final int pid) {
- Manager.host.requestProc(pid, new FindProc() {
- public void procFound(Proc p) {
- List tasks = p.getTasks();
- for (Iterator i = tasks.iterator(); i.hasNext();) {
- Task t = (Task) i.next();
- if (t.getTaskId().hashCode() == pid) {
- syscallObserver = new SyscallInterruptObserver(t);
- t.requestAddSyscallsObserver(syscallObserver);
- assertRunUntilStop("Add syscallObservers");
- t.requestAddSignaledObserver(syscallObserver);
- assertRunUntilStop("Add signaledObservers");
- }
- }
- Manager.eventLoop.requestStop();
- }
- public void procNotFound (int pid) {
- fail("proc not found " + pid);
- }
- });
- Manager.eventLoop.run();
- }
+ TestSyscallInterruptXXX(final int pid) {
+ Manager.host.requestProc(pid, new FindProc() {
+ public void procFound(Proc p) {
+ List tasks = p.getTasks();
+ for (Iterator i = tasks.iterator(); i.hasNext();) {
+ Task t = (Task) i.next();
+ if (t.getTid() == pid) {
+ syscallObserver = new SyscallInterruptObserver(t);
+ t.requestAddSyscallsObserver(syscallObserver);
+ assertRunUntilStop("Add syscallObservers");
+ t.requestAddSignaledObserver(syscallObserver);
+ assertRunUntilStop("Add signaledObservers");
+ }
+ }
+ Manager.eventLoop.requestStop();
+ }
+ public void procNotFound (int pid) {
+ fail("proc not found " + pid);
+ }
+ });
+ Manager.eventLoop.run();
+ }
}
/**
diff --git a/frysk-core/frysk/proc/dead/ChangeLog b/frysk-core/frysk/proc/dead/ChangeLog
index ae17b0a..b83e06f 100644
--- a/frysk-core/frysk/proc/dead/ChangeLog
+++ b/frysk-core/frysk/proc/dead/ChangeLog
@@ -1,5 +1,7 @@
2008-02-27 Andrew Cagney <cagney@redhat.com>
+ * TestLinuxCore.java: Do not use Task.getTaskId.
+
* TestCoreRegs.java: Use LinuxCoreFactory.
2008-02-26 Andrew Cagney <cagney@redhat.com>
diff --git a/frysk-core/frysk/proc/dead/TestLinuxCore.java b/frysk-core/frysk/proc/dead/TestLinuxCore.java
index 634a592..333780a 100644
--- a/frysk-core/frysk/proc/dead/TestLinuxCore.java
+++ b/frysk-core/frysk/proc/dead/TestLinuxCore.java
@@ -308,7 +308,6 @@ public class TestLinuxCore extends TestLib {
{
assertNotNull("Task exists in proc",tasks[i]);
- assertEquals("Task ID",threadPid[i],tasks[i].getTaskId().id);
assertEquals("Task TID",threadPid[i], tasks[i].getTid());
assertEquals("Task TID",threadName[i],tasks[i].getName());
assertNotNull("Task ISA",tasks[i].getISA());
hooks/post-receive
--
frysk system monitor/debugger
reply other threads:[~2008-02-27 18:12 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080227181240.20830.qmail@sourceware.org \
--to=cagney@sourceware.org \
--cc=frysk-cvs@sourceware.org \
--cc=frysk@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).