public inbox for frysk-cvs@sourceware.org help / color / mirror / Atom feed
From: cagney@sourceware.org To: frysk-cvs@sourceware.org Subject: [SCM] master: Make Proc.taskPool private. Date: Wed, 27 Feb 2008 19:03:00 -0000 [thread overview] Message-ID: <20080227190320.15237.qmail@sourceware.org> (raw) The branch, master has been updated via 9d48be0ed86dd7fb9ff9e4a4ab8ff2730d4f6f33 (commit) from d0389c68ba9e11e6ffacec53596d2b05425f1c4b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email. - Log ----------------------------------------------------------------- commit 9d48be0ed86dd7fb9ff9e4a4ab8ff2730d4f6f33 Author: Andrew Cagney <cagney@redhat.com> Date: Wed Feb 27 14:02:21 2008 -0500 Make Proc.taskPool private. frysk-core/frysk/proc/ChangeLog 2008-02-27 Andrew Cagney <cagney@redhat.com> * Proc.java (taskPool): Make private. frysk-core/frysk/proc/live/ChangeLog 2008-02-27 Andrew Cagney <cagney@redhat.com> * LinuxPtraceProcState.java: Do not use Proc.taskPool. * LinuxPtraceTaskState.java: Ditto. ----------------------------------------------------------------------- Summary of changes: frysk-core/frysk/proc/ChangeLog | 2 ++ frysk-core/frysk/proc/Proc.java | 2 +- frysk-core/frysk/proc/live/ChangeLog | 3 +++ .../frysk/proc/live/LinuxPtraceProcState.java | 2 +- .../frysk/proc/live/LinuxPtraceTaskState.java | 2 +- 5 files changed, 8 insertions(+), 3 deletions(-) First 500 lines of diff: diff --git a/frysk-core/frysk/proc/ChangeLog b/frysk-core/frysk/proc/ChangeLog index 3412eb1..64bdc69 100644 --- a/frysk-core/frysk/proc/ChangeLog +++ b/frysk-core/frysk/proc/ChangeLog @@ -1,5 +1,7 @@ 2008-02-27 Andrew Cagney <cagney@redhat.com> + * Proc.java (taskPool): Make private. + * Task.java (getTaskId()): Make package private. * TestTaskSyscallObserver.java: Use Task.getTid(). diff --git a/frysk-core/frysk/proc/Proc.java b/frysk-core/frysk/proc/Proc.java index 267d90e..f6f2b6b 100644 --- a/frysk-core/frysk/proc/Proc.java +++ b/frysk-core/frysk/proc/Proc.java @@ -321,7 +321,7 @@ public abstract class Proc implements Comparable { * * XXX: Should not be public. */ - public Map taskPool = new HashMap(); + private final Map taskPool = new HashMap(); /** * Add the Task to this Proc. diff --git a/frysk-core/frysk/proc/live/ChangeLog b/frysk-core/frysk/proc/live/ChangeLog index 495d229..6738280 100644 --- a/frysk-core/frysk/proc/live/ChangeLog +++ b/frysk-core/frysk/proc/live/ChangeLog @@ -1,5 +1,8 @@ 2008-02-27 Andrew Cagney <cagney@redhat.com> + * LinuxPtraceProcState.java: Do not use Proc.taskPool. + * LinuxPtraceTaskState.java: Ditto. + * LinuxPtraceProc.java (tasks): New. (removeTask(ProcessIdentifier)): New. (addTask(ProcessIdentifier,LinuxPtraceTask)): New. diff --git a/frysk-core/frysk/proc/live/LinuxPtraceProcState.java b/frysk-core/frysk/proc/live/LinuxPtraceProcState.java index f22f347..3dd8f3f 100644 --- a/frysk-core/frysk/proc/live/LinuxPtraceProcState.java +++ b/frysk-core/frysk/proc/live/LinuxPtraceProcState.java @@ -150,7 +150,7 @@ abstract class LinuxPtraceProcState extends State { observation.fail(new RuntimeException("not actually added")); // Grab the main task; only bother with the refresh if the // Proc has no clue as to its task list. - if (proc.taskPool.size () == 0) + if (proc.getTasks().size() == 0) proc.sendRefresh (); // Assumes that the main Task's ID == the Proc's ID. LinuxPtraceTask mainTask diff --git a/frysk-core/frysk/proc/live/LinuxPtraceTaskState.java b/frysk-core/frysk/proc/live/LinuxPtraceTaskState.java index 2c07389..a04daa7 100644 --- a/frysk-core/frysk/proc/live/LinuxPtraceTaskState.java +++ b/frysk-core/frysk/proc/live/LinuxPtraceTaskState.java @@ -164,7 +164,7 @@ class LinuxPtraceTaskState extends State { else task.notifyTerminated(false, status); // A process with no tasks is dead ...? - if (task.getProc().taskPool.size() == 0) { + if (task.getProc().getTasks().size() == 0) { task.getProc().parent.remove(task.getProc()); task.getProc().getHost().remove(task.getProc()); } hooks/post-receive -- frysk system monitor/debugger
reply other threads:[~2008-02-27 19:03 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20080227190320.15237.qmail@sourceware.org \ --to=cagney@sourceware.org \ --cc=frysk-cvs@sourceware.org \ --cc=frysk@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).