From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9431 invoked by alias); 31 Mar 2008 20:47:59 -0000 Received: (qmail 9400 invoked by uid 367); 31 Mar 2008 20:47:57 -0000 Date: Mon, 31 Mar 2008 20:47:00 -0000 Message-ID: <20080331204757.9384.qmail@sourceware.org> From: cagney@sourceware.org To: frysk-cvs@sourceware.org Subject: [SCM] master: Don't double-parse fexe . X-Git-Refname: refs/heads/master X-Git-Reftype: branch X-Git-Oldrev: b12abe2ed615acb2de7c967882c29b27b3bfbd66 X-Git-Newrev: ef004caee59a22972827bc8ee5fb2b7a105bb7cb Mailing-List: contact frysk-cvs-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: frysk-cvs-owner@sourceware.org Reply-To: frysk@sourceware.org X-SW-Source: 2008-q1/txt/msg00437.txt.bz2 The branch, master has been updated via ef004caee59a22972827bc8ee5fb2b7a105bb7cb (commit) from b12abe2ed615acb2de7c967882c29b27b3bfbd66 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email. - Log ----------------------------------------------------------------- commit ef004caee59a22972827bc8ee5fb2b7a105bb7cb Author: Andrew Cagney Date: Mon Mar 31 16:46:53 2008 -0400 Don't double-parse fexe . frysk-core/frysk/bindir/ChangeLog 2008-03-31 Andrew Cagney * ftrace.java (commandAndArguments): Change type to Proc. (run(String[])): Don't un-parse the commandAndArguments; pass to Ftrace.trace(Proc). frysk-core/frysk/ftrace/ChangeLog 2008-03-31 Andrew Cagney * Ftrace.java (trace(Proc)): Replace trace(String[]). ----------------------------------------------------------------------- Summary of changes: frysk-core/frysk/bindir/ChangeLog | 4 ++++ frysk-core/frysk/bindir/ftrace.java | 14 +++++--------- frysk-core/frysk/ftrace/ChangeLog | 4 ++++ frysk-core/frysk/ftrace/Ftrace.java | 2 +- 4 files changed, 14 insertions(+), 10 deletions(-) First 500 lines of diff: diff --git a/frysk-core/frysk/bindir/ChangeLog b/frysk-core/frysk/bindir/ChangeLog index 86abbed..74e1fbf 100644 --- a/frysk-core/frysk/bindir/ChangeLog +++ b/frysk-core/frysk/bindir/ChangeLog @@ -1,5 +1,9 @@ 2008-03-31 Andrew Cagney + * ftrace.java (commandAndArguments): Change type to Proc. + (run(String[])): Don't un-parse the commandAndArguments; pass to + Ftrace.trace(Proc). + * fstack.xml: Use abs_root_srcdir when specifying paths. * fstack.xml: Use stack-options.xml, standard-options.xml, and diff --git a/frysk-core/frysk/bindir/ftrace.java b/frysk-core/frysk/bindir/ftrace.java index 2efb84d..6774501 100644 --- a/frysk-core/frysk/bindir/ftrace.java +++ b/frysk-core/frysk/bindir/ftrace.java @@ -72,7 +72,7 @@ class ftrace { // True if a PID was requested. private boolean requestedPid; // Command and arguments to exec. - private ArrayList commandAndArguments; + private Proc commandAndArguments; // For configuration of overall working set. We need to load and // apply rules separately, to get all log messages, that's the @@ -314,10 +314,7 @@ class ftrace { //@Override public void parseCommand(Proc command) { - String[] line = command.getCmdLine(); - commandAndArguments = new ArrayList(); - for (int i = 0; i < line.length; i++) - commandAndArguments.add(line[i]); + commandAndArguments = command; } //@Override @@ -384,11 +381,10 @@ class ftrace { } if (commandAndArguments != null) { - String[] cmd = (String[]) commandAndArguments.toArray(new String[0]); - tracer.trace(cmd); - } - else + tracer.trace(commandAndArguments); + } else { tracer.trace(); + } } public ftrace() diff --git a/frysk-core/frysk/ftrace/ChangeLog b/frysk-core/frysk/ftrace/ChangeLog index e41545e..5f964f1 100644 --- a/frysk-core/frysk/ftrace/ChangeLog +++ b/frysk-core/frysk/ftrace/ChangeLog @@ -1,3 +1,7 @@ +2008-03-31 Andrew Cagney + + * Ftrace.java (trace(Proc)): Replace trace(String[]). + 2008-03-20 Andrew Cagney * Ftrace.java: Use ProcTasksAction and ProcTasksObserver. diff --git a/frysk-core/frysk/ftrace/Ftrace.java b/frysk-core/frysk/ftrace/Ftrace.java index d66e470..87776b0 100644 --- a/frysk-core/frysk/ftrace/Ftrace.java +++ b/frysk-core/frysk/ftrace/Ftrace.java @@ -189,7 +189,7 @@ public class Ftrace { new ProcTasksAction(proc, tasksObserver); } - public void trace (String[] command) { + public void trace(Proc command) { init(); Manager.host.requestCreateAttachedProc(command, attachedObserver); Manager.eventLoop.run(); hooks/post-receive -- frysk system monitor/debugger