public inbox for frysk@sourceware.org
 help / color / mirror / Atom feed
From: Mark Wielaard <mark@klomp.org>
To: frysk@sourceware.org
Cc: cagney@sourceware.org
Subject: Re: frysk-core/frysk/proc ChangeLog TestBreakpoint ...
Date: Thu, 12 Oct 2006 20:46:00 -0000	[thread overview]
Message-ID: <1160686006.3111.11.camel@dijkstra.wildebeest.org> (raw)
In-Reply-To: <20061012145206.6642.qmail@sourceware.org>

Hi Andrew,

On Thu, 2006-10-12 at 14:52 +0000, cagney@sourceware.org wrote:
> 	2006-10-12  Andrew Cagney  <cagney@redhat.com>
> 	
> 	* TestBreakpoints.java (setUp): Move code creating event loop from
> 	here ...
> 	(testHitAndRun, testInsertRemove, testAddLots): ... to here.
> 	(tearDown): Only shutdown the eventLoop when it is running.

This change doesn't make sense to me.
setUp() and tearDown() are called before and after every test, which is
why all common setup/teardown code is in those methods. Moving parts of
it into the individual tests makes the code harder to maintain imho.
Could you explain why you think it is necessary?

Also, could you please keep the file indentation (GNU style) please (*).

Thanks,

Mark

(*) For emacs the following will do it (in your .emacs) automagically:

(add-hook 'java-mode-hook
  (lambda ()
    (c-set-style "GNU")
    (c-set-offset 'inline-open 0)))

       reply	other threads:[~2006-10-12 20:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20061012145206.6642.qmail@sourceware.org>
2006-10-12 20:46 ` Mark Wielaard [this message]
2006-10-12 21:20   ` Andrew Cagney
2006-10-12 23:20     ` Mark Wielaard
2006-10-13 13:51       ` Andrew Cagney
2006-10-13 15:57         ` Mark Wielaard
2006-12-11 22:01           ` Andrew Cagney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1160686006.3111.11.camel@dijkstra.wildebeest.org \
    --to=mark@klomp.org \
    --cc=cagney@sourceware.org \
    --cc=frysk@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).