From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10312 invoked by alias); 12 Oct 2006 20:46:57 -0000 Received: (qmail 10296 invoked by uid 22791); 12 Oct 2006 20:46:56 -0000 X-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,FORGED_RCVD_HELO X-Spam-Check-By: sourceware.org Received: from wildebeest.demon.nl (HELO gnu.wildebeest.org) (83.160.170.119) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 12 Oct 2006 20:46:54 +0000 Received: from dijkstra.wildebeest.org ([192.168.1.29]) by gnu.wildebeest.org with esmtp (Exim 3.36 #1 (Debian)) id 1GY7SC-00048h-00; Thu, 12 Oct 2006 22:46:56 +0200 Subject: Re: frysk-core/frysk/proc ChangeLog TestBreakpoint ... From: Mark Wielaard To: frysk@sourceware.org Cc: cagney@sourceware.org In-Reply-To: <20061012145206.6642.qmail@sourceware.org> References: <20061012145206.6642.qmail@sourceware.org> Content-Type: text/plain Date: Thu, 12 Oct 2006 20:46:00 -0000 Message-Id: <1160686006.3111.11.camel@dijkstra.wildebeest.org> Mime-Version: 1.0 X-Mailer: Evolution 2.6.3 (2.6.3-1.fc5.5) Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact frysk-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Post: List-Help: , Sender: frysk-owner@sourceware.org X-SW-Source: 2006-q4/txt/msg00076.txt.bz2 Hi Andrew, On Thu, 2006-10-12 at 14:52 +0000, cagney@sourceware.org wrote: > 2006-10-12 Andrew Cagney > > * TestBreakpoints.java (setUp): Move code creating event loop from > here ... > (testHitAndRun, testInsertRemove, testAddLots): ... to here. > (tearDown): Only shutdown the eventLoop when it is running. This change doesn't make sense to me. setUp() and tearDown() are called before and after every test, which is why all common setup/teardown code is in those methods. Moving parts of it into the individual tests makes the code harder to maintain imho. Could you explain why you think it is necessary? Also, could you please keep the file indentation (GNU style) please (*). Thanks, Mark (*) For emacs the following will do it (in your .emacs) automagically: (add-hook 'java-mode-hook (lambda () (c-set-style "GNU") (c-set-offset 'inline-open 0)))