From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12665 invoked by alias); 6 Dec 2006 05:41:17 -0000 Received: (qmail 12653 invoked by uid 22791); 6 Dec 2006 05:41:16 -0000 X-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,TW_BG,TW_GT X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 06 Dec 2006 05:41:11 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11.20060308/8.12.11) with ESMTP id kB65f8aw024137; Wed, 6 Dec 2006 00:41:08 -0500 Received: from pobox.toronto.redhat.com (pobox.toronto.redhat.com [172.16.14.4]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id kB65f7dD030086; Wed, 6 Dec 2006 00:41:07 -0500 Received: from [127.0.0.1] (sebastian-int.corp.redhat.com [172.16.52.221]) by pobox.toronto.redhat.com (8.12.11.20060308/8.12.11) with ESMTP id kB65f6Xh003032; Wed, 6 Dec 2006 00:41:06 -0500 Subject: Re: [fedora-java] src.zip's and rpms in Eclipse From: Ben Konrath To: Nicolas Mailhot Cc: Andrew Overholt , fedora-devel-java-list@redhat.com, Frysk Hackers In-Reply-To: <1165355834.22822.4.camel@rousalka.dyndns.org> References: <456CDAE1.10006@redhat.com> <1164817735.2943.47.camel@to-dhcp1.toronto.redhat.com> <1164818423.30106.9.camel@toxic.toronto.redhat.com> <1164918343.3330.128.camel@plug> <1165355834.22822.4.camel@rousalka.dyndns.org> Content-Type: text/plain; charset=utf-8 Date: Wed, 06 Dec 2006 05:41:00 -0000 Message-Id: <1165378680.3004.69.camel@plug> Mime-Version: 1.0 X-Mailer: Evolution 2.8.2.1 (2.8.2.1-2.fc6) Content-Transfer-Encoding: 8bit X-IsSubscribed: yes Mailing-List: contact frysk-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: frysk-owner@sourceware.org X-SW-Source: 2006-q4/txt/msg00257.txt.bz2 On Tue, 2006-12-05 at 22:57 +0100, Nicolas Mailhot wrote: > Le jeudi 30 novembre 2006 à 15:25 -0500, Ben Konrath a écrit : > > > Yeah, that a good idea and I've wanted this for a while. I was thinking > > of checking a known location, for example if you add > > package-version.jar, it would auto-attach package-version-src.zip. This > > seems to be a convention that eclipse uses. But using a manifest file > > tag would be more robust. > > Manifest is not robust WRT file moves. It's redundant when everyone > follows the same conventions, and a PITA to track/change when you don't. I was thinking of somehow specifying the absolute path to the source zip in the manifest. If the source zip is packaged by the same srpm as jar, then the location should be known and users shouldn't be just randomly moving files around. But I agree that it would be a bit of a pain to modify every java RPM to add a path its manifest specifying the location of the source zip. > Much better to specify rigid file location & naming conventions, with > optional override of the root dir via an env var Seems reasonable. Eclipse tends to use the naming convention I mentioned in my initial response (above) so this is what I've been using. As an example, the libgtk-java packages has these files in /usr/share/java/: gtk2.8-2.8.7.jar gtk2.8.jar -> gtk2.8-2.8.7.jar gtk2.8-src-2.8.7.zip gtk2.8-src.zip -> gtk2.8-src-2.8.7.zip I think we should keep this naming convention and have eclipse automatically attach a source zips with the correct name (-src.{zip,jar}) if they are in the same directory as the external jar. If ECLIPSE_JDT_JAR_SRC_ZIP_DIR is set, Eclipse could try to load a zip/jar of the same name from the directory specified by this env variable. What do you think? Ben