public inbox for frysk@sourceware.org
 help / color / mirror / Atom feed
From: Mark Wielaard <mark@klomp.org>
To: Andrew Cagney <cagney@redhat.com>
Cc: frysk@sourceware.org
Subject: Re: fstep added
Date: Mon, 18 Dec 2006 19:41:00 -0000	[thread overview]
Message-ID: <1166470843.3022.36.camel@dijkstra.wildebeest.org> (raw)
In-Reply-To: <4586BC16.6090208@redhat.com>

On Mon, 2006-12-18 at 11:04 -0500, Andrew Cagney wrote:
> > You can also attach it to a running process with --pid.
> >   
> 
> Most of the other utilities are now sharing a common option framework.  
> Can you bug report the need to convert this code.

Filed as: http://sourceware.org/bugzilla/show_bug.cgi?id=3752

> > The following things can/should be improved:
> >
> > - It is currently build right on top of the Instruction TaskObserver. It
> > might be better to build it on top of the new rt framework. The rt
> > framework can probably also handle stepping over locking sequences like
> > on ppc (lwarx/stwcx).
> >   
> Yes, that's something unique to the PPC.  There's an existing bug for 
> this under the PPC blocker list.

I couldn't find the bug report. But I suppose this should be handled by
the rt RunState support and not directly in the proc TaskState.

> Yes, more efficient memory access will eventually be needed.  For 
> insttance, by mmapping the inferior address space (I know there are 
> kernel patches out there to do that), or performing larger transfers and 
> caching under the hood.  Both involve careful thought, especially when 
> it comes to invalidating caches, so for the moment, as you've done, the 
> focus remains on correctness.

Oh, nice idea. mmapping /proc/<pid>/mem would certainly speed things up.
I suppose you cannot write to it, but in most cases we only need to read
large amounts, not write them.

> > - It could give the name of the memory map the PC is currently in.
> >
> > - It could even give the source/line-number if available.
> >   
> 
> These are all good ideas.

I added them all as a comment to the (now suspended) fstep bug
http://sourceware.org/bugzilla/show_bug.cgi?id=3364

Cheers,

Mark

  reply	other threads:[~2006-12-18 19:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-18 14:01 Mark Wielaard
2006-12-18 16:05 ` Andrew Cagney
2006-12-18 19:41   ` Mark Wielaard [this message]
2007-01-22 13:52   ` Phil Muldoon
2007-01-22 16:19     ` Mark Wielaard
2007-01-22 19:00       ` Andrew Cagney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1166470843.3022.36.camel@dijkstra.wildebeest.org \
    --to=mark@klomp.org \
    --cc=cagney@redhat.com \
    --cc=frysk@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).