From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3597 invoked by alias); 6 Mar 2007 15:37:09 -0000 Received: (qmail 3588 invoked by uid 22791); 6 Mar 2007 15:37:09 -0000 X-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,FORGED_RCVD_HELO X-Spam-Check-By: sourceware.org Received: from wildebeest.demon.nl (HELO gnu.wildebeest.org) (83.160.170.119) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 06 Mar 2007 15:36:58 +0000 Received: from dijkstra.wildebeest.org ([192.168.1.29]) by gnu.wildebeest.org with esmtp (Exim 4.43) id 1HObjb-0004w8-JJ; Tue, 06 Mar 2007 16:37:51 +0100 Subject: Re: frysk-imports/frysk/expunit ChangeLog Equals.j ... From: Mark Wielaard To: Andrew Cagney Cc: frysk@sourceware.org In-Reply-To: <45ED8846.4080901@redhat.com> References: <20070305135202.24295.qmail@sourceware.org> <45ED8846.4080901@redhat.com> Content-Type: text/plain Date: Tue, 06 Mar 2007 15:37:00 -0000 Message-Id: <1173195413.4257.52.camel@dijkstra.wildebeest.org> Mime-Version: 1.0 X-Mailer: Evolution 2.8.3 (2.8.3-1.fc6) Content-Transfer-Encoding: 7bit X-Spam-Score: -4.4 (----) X-IsSubscribed: yes Mailing-List: contact frysk-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: frysk-owner@sourceware.org X-SW-Source: 2007-q1/txt/msg00177.txt.bz2 On Tue, 2007-03-06 at 10:27 -0500, Andrew Cagney wrote: > I don't follow these changes. If the code stripping of the matched text > was removed, then TestExpect and other code would start failing - was > this tested? And the grouping code is so that expect clients can access > the parts that were matched, that functionality was lost? Yes this was a mistake. Fixed in the followup patch. The warnings that the new ecj gave had me confused. Sorry about that. Cheers, Mark