multi-platform libunwind and frysk-import/configure.ac

multi-platform libunwind and frysk-import/configure.ac

[Nurdin Premji]

Copy of discussion with Stepan to be discussed on list.
Middle posting.
Stepan Kasal wrote:
> Hi Nurdin,
>
> attached please find a version of frysk-imports/configure.ac.
> It's just a first iteration.
>
> Random comments:
>   
>> test -d libunwind-i386 || mkdir libunwind-i386
>>     
>
> More portable than "mkdir -p", though not necessary in our case.
>
>   
>> AC_CONFIG_SUBDIRS([elfutils libunwind])
>>     
>
> I moved this lower.  It has no influence to the generated script,
> but I wanted to emphasize the fact that these dirs are configured
> _after_ our configure call (the sub-configure calls are part of the
> expansion of AC_OUTPUT).
>
>   
>> $confdir/libunwind/configure --target=i386-unknown-linux-gnu
>>     
>
> But this is just a rough cut, because this does not pass the options
> given to the outer configure.
>
> Well, you can add "--build=${build} --host=${host}" to pass the arch
> names (in case they were given on the cmd-line).
> We could try "--prefix=$prefix" to pass another bit of info.
>
> Unfortunately, passing all the options is not trivial, AFAIK.
> I would like to ask about this on autoconf@gnu.org, but before that I
> need a bigger picture: why is this needed?
>
>   
Well the reason why this has to be done is that we need to compile 
libunwind for each architecture we support in order to get 
multi-platform unwinding working. The example is to unwind a 32 bit 
application on a 64 bit architecture (as well as to also be able to 
unwind 64 bit applications) .  
http://www.hpl.hp.com/research/linux/libunwind/man/libunwind(3).php#section_4
David Mosberger-Tang has said in an email on the libunwind-devel mailing 
list that to do this we have to run the configure separately for each 
target.


> Perhaps you might want to mail the answer to the frysk@ list, so that
> our discussion is reviewed by the rest.
>
> (We might also check how gcc handles sub-configures.)
>
> Hope this helps,
> 	Stepan
>   
> ------------------------------------------------------------------------
>
> # This file is part of the program FRYSK.
> #
> # Copyright 2005, 2006, Red Hat Inc.
> #
> # FRYSK is free software; you can redistribute it and/or modify it
> # under the terms of the GNU General Public License as published by
> # the Free Software Foundation; version 2 of the License.
> #
> # FRYSK is distributed in the hope that it will be useful, but
> # WITHOUT ANY WARRANTY; without even the implied warranty of
> # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
> # General Public License for more details.
> # 
> # You should have received a copy of the GNU General Public License
> # along with FRYSK; if not, write to the Free Software Foundation,
> # Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA.
> # 
> # In addition, as a special exception, Red Hat, Inc. gives You the
> # additional right to link the code of FRYSK with code not covered
> # under the GNU General Public License ("Non-GPL Code") and to
> # distribute linked combinations including the two, subject to the
> # limitations in this paragraph. Non-GPL Code permitted under this
> # exception must only link to the code of FRYSK through those well
> # defined interfaces identified in the file named EXCEPTION found in
> # the source code files (the "Approved Interfaces"). The files of
> # Non-GPL Code may instantiate templates or use macros or inline
> # functions from the Approved Interfaces without causing the
> # resulting work to be covered by the GNU General Public
> # License. Only Red Hat, Inc. may make changes or additions to the
> # list of Approved Interfaces. You must obey the GNU General Public
> # License in all respects for all of the FRYSK code and other code
> # used in conjunction with FRYSK except the Non-GPL Code covered by
> # this exception. If you modify this file, you may extend this
> # exception to your version of the file, but you are not obligated to
> # do so. If you do not wish to provide this exception without
> # modification, you must delete this exception statement from your
> # version and license this file solely under the GPL without
> # exception.
>
> AC_PREREQ(2.59)
>
> sinclude(common/version.ac)
> AC_INIT(frysk, [FRYSK_VERSION])
>
> m4_include([common/frysk-common.ac])
>
> AM_INIT_AUTOMAKE([subdir-objects foreign no-installinfo no-exeext])
>
> AC_FIND_FILE([antlr.jar], [/usr/share/java /usr/share/frysk/java], ANTLR_JAR)
> AC_FIND_FILE([jdom.jar], [/usr/share/java /usr/share/frysk/java], JDOM_JAR)
> AC_FIND_FILE([libaudit.h], [/usr/include/], LIBAUDIT_H)
>
> AC_CONFIG_FILES([
> 	Makefile
> 	jline/Makefile
> 	getopt/Makefile
> 	tests/Makefile
> 	cdtparser/Makefile
> 	junit/Makefile])
>
>
> test -d libunwind-i386 || mkdir libunwind-i386
> (
>   confdir=`(cd "$srcdir";pwd)`
>   cd libunwind-i386
>   # Make sure the inplace build does not break with "already configured"
>   # message; the file is going to regenerated, anyway.
>   rm -f $confdir/libunwind/config.status
>   $confdir/libunwind/configure --target=i386-unknown-linux-gnu
> )
>
> AC_CONFIG_SUBDIRS([elfutils libunwind])
>
> AC_OUTPUT
>   

Re: multi-platform libunwind and frysk-import/configure.ac

[Stepan Kasal]

Hello,

On Thu, Mar 22, 2007 at 02:42:28PM -0400, Nurdin Premji wrote:
> >>$confdir/libunwind/configure --target=i386-unknown-linux-gnu

> Well the reason why this has to be done is that we need to compile 
> libunwind for each architecture we support in order to get 
> multi-platform unwinding working.

At first glance, I'd guess that implementing this with one configure
only might be easier.  I'll give it a try and report here.

Cheers,
	Stepan

Re: multi-platform libunwind and frysk-import/configure.ac

[Mark Wielaard]

Hi Stepan,

On Thu, 2007-03-22 at 20:08 +0100, Stepan Kasal wrote:
> On Thu, Mar 22, 2007 at 02:42:28PM -0400, Nurdin Premji wrote:
> > >>$confdir/libunwind/configure --target=i386-unknown-linux-gnu
> 
> > Well the reason why this has to be done is that we need to compile 
> > libunwind for each architecture we support in order to get 
> > multi-platform unwinding working.
> 
> At first glance, I'd guess that implementing this with one configure
> only might be easier.  I'll give it a try and report here.

Did you have any luck with this? The way it is currently done just
discards any configure flags normally used, which breaks unless you only
use all the defaults (no options to autogen.sh). I am a bit stuck how to
handle this and need to get frysk installed again to try to replicate a
bug. See also: http://sourceware.org/bugzilla/show_bug.cgi?id=4279

Thanks,

Mark

Re: multi-platform libunwind and frysk-import/configure.ac

[Mark Wielaard]

On Tue, 2007-03-27 at 12:51 +0200, Mark Wielaard wrote:
> On Thu, 2007-03-22 at 20:08 +0100, Stepan Kasal wrote:
> > On Thu, Mar 22, 2007 at 02:42:28PM -0400, Nurdin Premji wrote:
> > > >>$confdir/libunwind/configure --target=i386-unknown-linux-gnu
> > 
> > > Well the reason why this has to be done is that we need to compile 
> > > libunwind for each architecture we support in order to get 
> > > multi-platform unwinding working.
> > 
> > At first glance, I'd guess that implementing this with one configure
> > only might be easier.  I'll give it a try and report here.
> 
> Did you have any luck with this? The way it is currently done just
> discards any configure flags normally used, which breaks unless you only
> use all the defaults (no options to autogen.sh). I am a bit stuck how to
> handle this and need to get frysk installed again to try to replicate a
> bug. See also: http://sourceware.org/bugzilla/show_bug.cgi?id=4279

Saw your suggestion earlier in the thread:

>> $confdir/libunwind/configure --target=i386-unknown-linux-gnu
>>     
> But this is just a rough cut, because this does not pass the options
> given to the outer configure.
>
> Well, you can add "--build=${build} --host=${host}" to pass the arch
> names (in case they were given on the cmd-line).
> We could try "--prefix=$prefix" to pass another bit of info.

And I added that workaround for now:

2007-03-27  Mark Wielaard  <mark@klomp.org>

        * configure.ac: Pass on host, build and prefix to libunwind-i386
        configure (and add FIXME).

Thanks,

Mark

diff -u -r1.66 configure.ac
--- configure.ac        22 Mar 2007 20:08:55 -0000      1.66
+++ configure.ac        27 Mar 2007 11:04:09 -0000
@@ -65,8 +65,11 @@
   cd libunwind-i386
   # Make sure the inplace build does not break with "already configured"
   # message; the file is going to regenerated, anyway.
+  # FIXME - This is wrong since it discards any configure flags given
+  # except those explicitly passed on...
   rm -f $confdir/libunwind/config.status
-  $confdir/libunwind/configure --target=i386-unknown-linux-gnu
+  $confdir/libunwind/configure --target=i386-unknown-linux-gnu \
+       --build=${build} --host=${host} --prefix=${prefix}
 )
 
 AC_CONFIG_SUBDIRS([elfutils libunwind])