Re: frysk-core/frysk/proc ChangeLog IsaFactory.jav ...

Re: frysk-core/frysk/proc ChangeLog IsaFactory.jav ...

[Andrew Cagney]

Chris,

Can we please not add code like this.   Mark earlier mentioned this, If 
you're building from rawhide then check with mark for the options to 
specify to stop these warnings.

Andrew


cmoller@sourceware.org wrote:
> CVSROOT:	/cvs/frysk
> Module name:	frysk-core
> Changes by:	cmoller@sourceware.org	2007-04-18 16:29:23
>
> Modified files:
> 	frysk/proc     : ChangeLog IsaFactory.java 
> 	                 LinuxPtraceProcState.java 
>
> Log message:
> 	fakeout unused parm warnings/errors
>
> Patches:
> http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-core/frysk/proc/ChangeLog.diff?cvsroot=frysk&r1=1.672&r2=1.673
> http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-core/frysk/proc/IsaFactory.java.diff?cvsroot=frysk&r1=1.17&r2=1.18
> http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-core/frysk/proc/LinuxPtraceProcState.java.diff?cvsroot=frysk&r1=1.1&r2=1.2
>
>   

Re: frysk-core/frysk/proc ChangeLog IsaFactory.jav ...

[Mark Wielaard]

On Wed, 2007-04-18 at 13:37 -0400, Andrew Cagney wrote:
> Can we please not add code like this.   Mark earlier mentioned this, If 
> you're building from rawhide then check with mark for the options to 
> specify to stop these warnings.

Which is super crude: configure --disable-werror
But it works for now on rawhide.
Note that this comes from 2 issues.

1) -Wall didn't work correctly before.
2) The new gcj/ecj combination adds lots of new warnings which because
   of 1) now ALL get properly enabled with -Wall)

So the right thing to do is to actually look for which warning we really
want to enable and to drop -Wall for gcj.

Cheers,

Mark