From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26827 invoked by alias); 14 Jun 2007 10:11:19 -0000 Received: (qmail 26816 invoked by uid 22791); 14 Jun 2007 10:11:18 -0000 X-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,DK_POLICY_SIGNSOME,FORGED_RCVD_HELO,TW_GC X-Spam-Check-By: sourceware.org Received: from wildebeest.demon.nl (HELO gnu.wildebeest.org) (83.160.170.119) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 14 Jun 2007 10:11:14 +0000 Received: from dijkstra.wildebeest.org ([192.168.1.29]) by gnu.wildebeest.org with esmtp (Exim 4.43) id 1HymKW-0002yD-FL; Thu, 14 Jun 2007 12:13:29 +0200 Subject: Re: adopting OpenJDK's coding standard[?]? From: Mark Wielaard To: Andrew Cagney Cc: frysk@sourceware.org In-Reply-To: <466FEC94.4000808@redhat.com> References: <466FEC94.4000808@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-O+DXZxMniyZwAiK0UMpn" Date: Thu, 14 Jun 2007 11:57:00 -0000 Message-Id: <1181815871.4474.34.camel@dijkstra.wildebeest.org> Mime-Version: 1.0 X-Mailer: Evolution 2.8.3 (2.8.3-2.fc6) X-Spam-Score: -4.4 (----) X-Virus-Checked: Checked by ClamAV on sourceware.org X-IsSubscribed: yes Mailing-List: contact frysk-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: frysk-owner@sourceware.org X-SW-Source: 2007-q2/txt/msg00270.txt.bz2 --=-O+DXZxMniyZwAiK0UMpn Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Content-length: 1630 Hi, On Wed, 2007-06-13 at 09:09 -0400, Andrew Cagney wrote: > Since OpenJDK is going to subsume CLASSPATH as the Free Java library,=20 > and OpenJDK follows Sun/Java coding conventions (sort of mostly :-), I=20 > can't think of a reason for continuing with the GNU format. In=20 > addition, its the format that EMACS already follows; and there should be= =20 > good indentation tools around. The only -ve is that Eclipse might still= =20 > need to be, er, "tweaked". >=20 > Topic for todays meeting. As I said in the meeting, but I didn't see the minutes yet, I think changing coding conventions is a bad idea. It is basically a bikeshed discussion waiting to happen [1] and everybody can come up with good arguments for or against any style. We have a Frysk style now and I would like to just stick with it instead of randomly changing it every so often. Just to insert my own bikeshed arguments: - I like the project to have one consistent style. Switching between styles just because one part is written in C, C++ or Java doesn't make sense to me. - We aren't based on OpenJDK, we use gcj and will for a time unless someone starts adding CNI support to OpenJDK or rewrite all our current wrappers and native code to support JNI (which will require analysis of performance impacts again since JNI and CNI have very different performance characteristics). GCJ obviously also uses GNU style like we do now. - And finally I like GNU style a lot better because the start and end of code blocks are so clear to find, something the proposed Sun coding style guide completely misses. Cheers, Mark [1] http://www.bikeshed.com/ --=-O+DXZxMniyZwAiK0UMpn Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part Content-length: 189 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (GNU/Linux) iD8DBQBGcRQ5xVhZCJWr9QwRArZcAKCKtOI+X3EWCvBogGZslgk/4VOjUwCfTELl Md3k5KvO2/Ldn16ndZU3Jhw= =Pgcp -----END PGP SIGNATURE----- --=-O+DXZxMniyZwAiK0UMpn--