public inbox for frysk@sourceware.org
 help / color / mirror / Atom feed
From: Mark Wielaard <mark@klomp.org>
To: Andrew Cagney <cagney@redhat.com>
Cc: frysk <frysk@sourceware.org>
Subject: Re: frysk.proc.{ptrace,corefile} -> frysk.proc.{live,dead}
Date: Tue, 19 Jun 2007 08:59:00 -0000	[thread overview]
Message-ID: <1182241970.4459.21.camel@dijkstra.wildebeest.org> (raw)
In-Reply-To: <467706B8.3050108@redhat.com>

On Mon, 2007-06-18 at 19:29 -0400, Andrew Cagney wrote: 
> > That is good. But what I am missing is the actual problem statement.
> > What exactly isn't possible today and what is possible tomorrow after
> > such a change is made. My concern is that some of this is just
> > refactoring for refactorings sake. That is why I ask the why and what
> > questions.
> >
> Sorry I don't follow, the but.  This is good.

Try showing that it is good and what the problem it is that it solves
with some concrete examples. An simple example of existing code and what
it should/could be might make things a lot more concrete and clear for
others to see which actual problem this solves.

> On Mon, 2007-06-18 at 18:27 -0400, Andrew Cagney wrote:
> Mark Wielaard wrote:
> >
> > We can certainly refactor the proc interfaces and implementation
> > subpackages. But you are mixing two things in your plan. The renaming of
> > existing packages and classes (which I don't see any benefit of) and
> > exposing flaws in of the refactoring of the proc, proc.ptrace and
> > proc.core code because there is a clear separation between interface and
> > implementation.
> >   
> Sorry, I don't follow, what do you think I am planning, and why do you 
> think it is mixed?

You don't make a clear distinction between on the one hand what exactly
you propose to move from the proc interfaces into the ptrace and core
implementation packages, and on the other hand the complete renaming of
the packages plus introduction of the new live and dead concepts.

I believe these new concepts of live and dead aren't really different
from the ptrace vs core distinction we have now. And if so then renaming
everything doesn't solve any actual problem, but just introduces random
change. But your examples don't make this clear to me.

My proposal is that you first describe the separation of interface and
implementation between proc, ptrace and core, and then if we have a good
separation between interface packages and implementation packages then
you introduce the live and dead property concepts based on that.

Cheers,

Mark

  reply	other threads:[~2007-06-19  8:32 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-13 13:17 Andrew Cagney
2007-06-14 10:11 ` Mark Wielaard
2007-06-14 14:08   ` Andrew Cagney
2007-06-15  9:05     ` Mark Wielaard
2007-06-15 15:04       ` Andrew Cagney
2007-06-15 19:44         ` Mark Wielaard
2007-06-18 18:15           ` Andrew Cagney
2007-06-18 19:06             ` Mark Wielaard
2007-06-18 23:29               ` Andrew Cagney
2007-06-19  8:59                 ` Mark Wielaard [this message]
2007-06-19 22:30                   ` Andrew Cagney
2007-06-20  9:21                     ` Mark Wielaard
2007-06-19  8:32               ` Andrew Cagney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1182241970.4459.21.camel@dijkstra.wildebeest.org \
    --to=mark@klomp.org \
    --cc=cagney@redhat.com \
    --cc=frysk@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).