From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4437 invoked by alias); 27 Jun 2007 08:43:13 -0000 Received: (qmail 4347 invoked by uid 22791); 27 Jun 2007 08:43:12 -0000 X-Spam-Status: No, hits=-1.2 required=5.0 tests=AWL,BAYES_00,DK_POLICY_SIGNSOME,FORGED_RCVD_HELO,SARE_PROLOSTOCK_SYM3,TW_OV X-Spam-Check-By: sourceware.org Received: from wildebeest.demon.nl (HELO gnu.wildebeest.org) (83.160.170.119) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 27 Jun 2007 08:43:09 +0000 Received: from dijkstra.wildebeest.org ([192.168.1.29]) by gnu.wildebeest.org with esmtp (Exim 4.43) id 1I3T9U-0008Mw-W0; Wed, 27 Jun 2007 10:45:30 +0200 Subject: Re: frysk-imports/include frysk-asm.h From: Mark Wielaard To: frysk@sourceware.org Cc: jflavio@sourceware.org In-Reply-To: <20070627022246.5602.qmail@sourceware.org> References: <20070627022246.5602.qmail@sourceware.org> Content-Type: text/plain Date: Wed, 27 Jun 2007 08:57:00 -0000 Message-Id: <1182933784.1046.10.camel@dijkstra.wildebeest.org> Mime-Version: 1.0 X-Mailer: Evolution 2.8.3 (2.8.3-2.fc6) Content-Transfer-Encoding: 7bit X-Spam-Score: -4.4 (----) X-IsSubscribed: yes Mailing-List: contact frysk-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: frysk-owner@sourceware.org X-SW-Source: 2007-q2/txt/msg00394.txt.bz2 Hi Jose, Hi On Wed, 2007-06-27 at 02:22 +0000, jflavio@sourceware.org wrote: > Log message: > Adding basic frysk-assembler macros for PowerPC64. > > Patches: > http://sourceware.org/cgi-bin/cvsweb.cgi/frysk-imports/include/frysk-asm.h.diff?cvsroot=frysk&r1=1.5&r2=1.6 This also removed some of the defines for other architectures, which broke the build: > --- frysk-imports/include/frysk-asm.h 2007/06/21 19:34:17 1.5 > +++ frysk-imports/include/frysk-asm.h 2007/06/27 02:22:46 1.6 > @@ -83,9 +83,6 @@ > #define REG2 %rdi > #define REG3 %rsi > #define REG4 %rdx > -#define BASEP %rbp > -#define STACKP %rsp > -#define IPREG %rip > > #define NO_OP nop > #define ENTER pushq %rbp; movq %rsp, %rbp > @@ -96,15 +93,6 @@ > #define LOAD_IMMED(DEST_REG,CONST) mov $CONST, DEST_REG > #define STORE(SOURCE_REG,BASE_REG) mov SOURCE_REG, (BASE_REG) > #define COMPARE_IMMED(REG,CONST) cmp $CONST, REG > -#define PUSHQ(REG) pushq REG > -#define MOVQ(A, B) movq A, B > -#define MOVL(A, B) movl A, B > -#define ADDL(A, B) addl $A, B > -#define SUBQ(A, B) subq $A, B > -#define TESTL(A, B) testl A, B > -#define PUSHQ_BASE pushq %rbp > -#define MOVQ_STACK movq %rsp, %rbp > -#define LEAVE leave; ret Please be careful when changing files and use cvs diff first to check whether it only contains specific changes you intend to commit. I fixed it by putting these defines back: 2007-06-27 Mark Wielaard * frysk-asm.h: Various x86 defines back. Also added a ChangeLog entry for your original change: 2007-06-26 Jose Flavio Aguilar Paulino * frysk-asm.h: Adding basic frysk-assembler macros for PowerPC64. Cheers, Mark diff -u -r1.6 frysk-asm.h --- frysk-imports/include/frysk-asm.h 27 Jun 2007 02:22:46 -0000 1.6 +++ frysk-imports/include/frysk-asm.h 27 Jun 2007 08:40:36 -0000 @@ -83,6 +83,10 @@ #define REG2 %rdi #define REG3 %rsi #define REG4 %rdx +#define BASEP %rbp +#define STACKP %rsp +#define IPREG %rip + #define NO_OP nop #define ENTER pushq %rbp; movq %rsp, %rbp @@ -93,6 +97,15 @@ #define LOAD_IMMED(DEST_REG,CONST) mov $CONST, DEST_REG #define STORE(SOURCE_REG,BASE_REG) mov SOURCE_REG, (BASE_REG) #define COMPARE_IMMED(REG,CONST) cmp $CONST, REG +#define PUSHQ(REG) pushq REG +#define MOVQ(A, B) movq A, B +#define MOVL(A, B) movl A, B +#define ADDL(A, B) addl $A, B +#define SUBQ(A, B) subq $A, B +#define TESTL(A, B) testl A, B +#define PUSHQ_BASE pushq %rbp +#define MOVQ_STACK movq %rsp, %rbp +#define LEAVE leave; ret //XXX: Need the following to be defined in order to compile. See Bug #3968 //Intel moves from right to left.