From: Mark Wielaard <mark@klomp.org>
To: frysk@sourceware.org
Subject: [patch] PickProcDialog vs Proc.getExe()
Date: Wed, 25 Jul 2007 12:07:00 -0000 [thread overview]
Message-ID: <1185365221.3597.25.camel@dijkstra.wildebeest.org> (raw)
In-Reply-To: <1185364424.3597.18.camel@dijkstra.wildebeest.org>
Hi,
On Wed, 2007-07-25 at 13:53 +0200, Mark Wielaard wrote:
> This break FryskGui which isn't prepared to handle null from Proc.get().
Here is a workaround for at least one case (there might be others, but I
haven't looked too deeply yet). This gets FryskGui up and running again
for me.
2007-07-25 Mark Wielaard <mwielaard@redhat.com>
* PickProcDialog.java (ProcCreatedObserver.run): Check whether
Proc.getExe() returns null before constructing File path.
Cheers,
Mark
diff -u -r1.12 PickProcDialog.java
--- frysk-gui/frysk/gui/monitor/PickProcDialog.java 30 Jan 2007 00:18:21 -0000 1.12
+++ frysk-gui/frysk/gui/monitor/PickProcDialog.java 25 Jul 2007 11:55:53 -0000
@@ -355,11 +355,14 @@
{
iterMap.put(proc.getCommand(), process);
treeStore.setValue(process, nameDC, proc.getCommand());
- File path = new File(proc.getExe());
-
- if (path != null)
- treeStore.setValue(process, locationDC,
- justPath(path.getPath(), path.getName()));
+
+ String exe = proc.getExe();
+ if (exe != null)
+ {
+ File path = new File(exe);
+ treeStore.setValue(process, locationDC,
+ justPath(path.getPath(), path.getName()));
+ }
else
treeStore.setValue(process, locationDC, "");
prev parent reply other threads:[~2007-07-25 12:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070718191111.26695.qmail@sourceware.org>
2007-07-25 11:53 ` frysk-sys/frysk bindir/ChangeLog proc/live/Cha Mark Wielaard
2007-07-25 12:07 ` Mark Wielaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1185365221.3597.25.camel@dijkstra.wildebeest.org \
--to=mark@klomp.org \
--cc=frysk@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).