Hi,

Phil and me were discussing cleaning up some of the
Memory/RegisterBuffers between ptrace and core proc Tasks on irc and
noticed that CoredumpAction was accessing the RegisterBanks directly
through the Isa. To make splitting the issue of getting the
RegisterBanks (Task specific) and doing the Register name mapping to
bank number and offset (Isa specific) easier we wanted to make all code
go through Task.getRegisterBanks(). This patch does that for
CoredumpAction:

2007-07-30  Mark Wielaard  <mwielaard@redhat.com>

    * CoredumpAction.java (): Use Task.getRegisterBanks() not
    Isa.getRegisterBankBuffers().

Tested on x86 and x86_64 without regressions.

Cheers,

Mark

diff -u -r1.16 CoredumpAction.java
--- frysk-core/frysk/util/CoredumpAction.java   16 Jul 2007 22:11:35 -0000     1.16
+++ frysk-core/frysk/util/CoredumpAction.java   30 Jul 2007 16:40:07 -0000
@@ -235,11 +235,8 @@
   {
     // New PRSTATUS Note Entry.
     ElfPrFPRegSet fpRegSet = new ElfPrFPRegSet();
-    Isa register = null;
-
-    register = task.getIsa();
 
-    ByteBuffer registerMaps[] = register.getRegisterBankBuffers(task.getProc().getPid());
+    ByteBuffer registerMaps[] = task.getRegisterBanks();
     if (registerMaps[1].capacity() <= 0)
       abandonCoreDump(new RuntimeException("FP Register bank is <=0"));
     byte[] regBuffer = new byte[(int) registerMaps[1].capacity()];