From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28226 invoked by alias); 30 Jul 2007 16:53:12 -0000 Received: (qmail 28219 invoked by uid 22791); 30 Jul 2007 16:53:12 -0000 X-Spam-Status: No, hits=-1.3 required=5.0 tests=AWL,BAYES_05,DK_POLICY_SIGNSOME,FORGED_RCVD_HELO X-Spam-Check-By: sourceware.org Received: from wildebeest.demon.nl (HELO gnu.wildebeest.org) (83.160.170.119) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 30 Jul 2007 16:53:08 +0000 Received: from dijkstra.wildebeest.org ([192.168.1.29]) by gnu.wildebeest.org with esmtp (Exim 4.43) id 1IFYX3-0007rR-Se; Mon, 30 Jul 2007 18:55:46 +0200 Subject: Make CoredumpAction use Task.getRegisterBanks() From: Mark Wielaard To: frysk@sourceware.org Cc: Phil Muldoon Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-17DSajTMITVDXcYYyWHC" Date: Mon, 30 Jul 2007 16:53:00 -0000 Message-Id: <1185814384.3674.36.camel@dijkstra.wildebeest.org> Mime-Version: 1.0 X-Mailer: Evolution 2.8.3 (2.8.3-2.fc6) X-Spam-Score: -4.4 (----) X-Virus-Checked: Checked by ClamAV on sourceware.org X-IsSubscribed: yes Mailing-List: contact frysk-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: frysk-owner@sourceware.org X-SW-Source: 2007-q3/txt/msg00225.txt.bz2 --=-17DSajTMITVDXcYYyWHC Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Content-length: 1404 Hi, Phil and me were discussing cleaning up some of the Memory/RegisterBuffers between ptrace and core proc Tasks on irc and noticed that CoredumpAction was accessing the RegisterBanks directly through the Isa. To make splitting the issue of getting the RegisterBanks (Task specific) and doing the Register name mapping to bank number and offset (Isa specific) easier we wanted to make all code go through Task.getRegisterBanks(). This patch does that for CoredumpAction: 2007-07-30 Mark Wielaard * CoredumpAction.java (): Use Task.getRegisterBanks() not Isa.getRegisterBankBuffers(). Tested on x86 and x86_64 without regressions. Cheers, Mark diff -u -r1.16 CoredumpAction.java --- frysk-core/frysk/util/CoredumpAction.java 16 Jul 2007 22:11:35 -0000 = 1.16 +++ frysk-core/frysk/util/CoredumpAction.java 30 Jul 2007 16:40:07 -0000 @@ -235,11 +235,8 @@ { // New PRSTATUS Note Entry. ElfPrFPRegSet fpRegSet =3D new ElfPrFPRegSet(); - Isa register =3D null; - - register =3D task.getIsa(); =20 - ByteBuffer registerMaps[] =3D register.getRegisterBankBuffers(task.get= Proc().getPid()); + ByteBuffer registerMaps[] =3D task.getRegisterBanks(); if (registerMaps[1].capacity() <=3D 0) abandonCoreDump(new RuntimeException("FP Register bank is <=3D0")); byte[] regBuffer =3D new byte[(int) registerMaps[1].capacity()]; --=-17DSajTMITVDXcYYyWHC Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part Content-length: 189 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (GNU/Linux) iD8DBQBGrhdqxVhZCJWr9QwRAmZDAJ9diYVj2BLHM1sgIj4X3uAkaHikugCgmtPf xTT7qFfm8Yk57AN47mp61XY= =vn1S -----END PGP SIGNATURE----- --=-17DSajTMITVDXcYYyWHC--