Hi,

Petr found a bug with adding and observer multiple times and then
deleting it. He even wrote a testcase for it. The issue was that you
could add an observation for different events (or in his particular case
watch an breakpoint on multiple addresses) but that Proc doesn't know
about this and treats the double add and one delete as if the observer
should be deleted completely, so if you delete it for the another event
(address) the Proc sanity check kicks in and flags it as a double
delete. The following patch fixes that (and makes the test case slightly
more deterministic):

2007-08-06  Mark Wielaard  <mark@klomp.org>

    Fixes bug #4894
    * Proc.java (observations): Turn into a Collection that can
    contain an observer multiple times.
    * TestTaskObserverCode.java (testCodeRemovedInHit): Explicitly
    wait for add and delete.

With this patch the test case now succeeds and no regressions (tested on
x86_64 FC6).

Cheers,

Mark