Re: New Libunwind for Power Fix

[Mark Wielaard <mark@klomp.org>]

Hi Jose,

On Thu, 2007-10-11 at 13:35 -0300, Jose Flavio Aguilar Paulino wrote:
> This patch fix the libunwind that was recently imported.
> Through this libunwind can properly compile for Power64 and Power32.

Thanks! I added these patches as follows:

frysk-imports/libunwind/ChangeLog:
2007-10-12  Jose Flavio Aguilar Paulino  <jflavio@br.ibm.com>

  * include/tdep-ppc32/libunwind_i.h: Define tdep_fetch_proc_info_post.
  (tdep_get_elf_image): Add void *arg argument.
  * include/tdep-ppc64/libunwind_i.h: Likewise.
  * src/Makefile.am (libunwind_la_SOURCES_ppc): Add
  ppc/Lfetch_proc_info_post.c.
  (libunwind_ppc_la_SOURCES_ppc_generic): Add
  ppc/Gfetch_proc_info_post.c.
  * src/ppc/Gfetch_proc_info_post.c: New file.
  * src/ppc/Lfetch_proc_info_post.c: New file.
  * src/ppc32/Ginit.c (get_static_proc_name): Pass through arg.
  * src/ppc64/Ginit.c (get_static_proc_name): Likewise.

I also added ppc32 as proper libunwind target in the frysk build so
things get configured and build properly by default now:

frysk-imports/ChangeLog:
2007-10-12  Mark Wielaard  <mwielaard@redhat.com>

  * Makefile.am: Set LIBUNWIND_ARCH_DIR, LIBUNWIND_OTHER_DIRS and
  GEN_GCJ_LDADD_LIST to include ppc32 target.
  * bootstrap.sh: Add ppc32 to isa list.

common/ChangeLog:
2007-10-12  Mark Wielaard  <mwielaard@redhat.com>

  * m4/frysk-use-libunwind.m4: Check for and transform powerpc target
  to ppc32.

frysk-imports/libunwind/ChangeLog:
2007-10-12  Mark Wielaard  <mwielaard@redhat.com>

  * src/ppc32/ucontext_i.h: Use locally defined reg structs.

As you see I had to add a similar patch to ppc32/ucontext_i.h that I
send you for ppc64/ucontext_i.h earlier because we want to be able to
compile for targets on hosts that might not have the kernel headers with
those structures in them available. Please do double check, I didn't
have a ppc machine available to test.

On each target you can build frysk with --enable-check-libunwind which
will build the tests for that particular target for a make check that
you can then compare with libunwind upstream results. They should be
fairly comparable (modulo a few extra/adjusted tests in frysk).
See http://sourceware.org/ml/frysk/2007-q4/msg00022.html

To complete unwinding/stack support in frysk for ppc some more work is
necessary:

- frysk-sys/lib/unwind and cni support should be added.
  This isn't particularly hard, see the existing
  UnwindRegisters[X86].shenum,shjava and cni/Unwind[X86].cxx examples.
  Just need to make sure that the right mappings to/from registers and
  the right libunwind target is selected.
- frysk-core/frysk/stack/LibunwindAddressSpace.java
  Should select the right unwind target (has hardcoded dependencies on
  x86/x86_64 currently).
- frysk-core/frys/isa/ Registers and frysk-core/frysk/proc Task should
  have the correct register names, register banks and selection.
  Andrew is currently reorganizing this code (see his recent messages
  to the list).

Cheers,

Mark

P.S. I will be without internet access for a couple of days, so I might
take a while to respond to questions.