From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2267 invoked by alias); 13 Oct 2007 18:16:55 -0000 Received: (qmail 2259 invoked by uid 22791); 13 Oct 2007 18:16:54 -0000 X-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,DK_POLICY_SIGNSOME,FORGED_RCVD_HELO X-Spam-Check-By: sourceware.org Received: from wildebeest.demon.nl (HELO gnu.wildebeest.org) (83.160.170.119) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 13 Oct 2007 18:16:52 +0000 Received: from dijkstra.wildebeest.org ([192.168.1.29]) by gnu.wildebeest.org with esmtp (Exim 4.63) (envelope-from ) id 1IglXc-0002m6-5w for frysk@sourceware.org; Sat, 13 Oct 2007 20:16:49 +0200 Subject: Re: frysk-core/frysk debuginfo/ChangeLog debuginfo ... From: Mark Wielaard To: frysk@sourceware.org In-Reply-To: <20071012215305.26224.qmail@sourceware.org> References: <20071012215305.26224.qmail@sourceware.org> Content-Type: multipart/mixed; boundary="=-WrUAFyo4/5sT6ccYVjWt" Date: Sat, 13 Oct 2007 18:16:00 -0000 Message-Id: <1192299407.3905.58.camel@dijkstra.wildebeest.org> Mime-Version: 1.0 X-Mailer: Evolution 2.8.3 (2.8.3-2.fc6) X-Spam-Score: -4.4 (----) X-Virus-Checked: Checked by ClamAV on sourceware.org X-IsSubscribed: yes Mailing-List: contact frysk-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: frysk-owner@sourceware.org X-SW-Source: 2007-q4/txt/msg00048.txt.bz2 --=-WrUAFyo4/5sT6ccYVjWt Content-Type: text/plain Content-Transfer-Encoding: 7bit Content-length: 1156 Hi Andrew, On Fri, 2007-10-12 at 21:53 +0000, cagney@sourceware.org wrote: > Index: frysk-core/frysk/debuginfo/ChangeLog > 2007-10-12 Andrew Cagney > > * DebugInfo.java: Update; do not throw NameNotFoundException. Do > not use CExprAnnotator. > * DebugInfoEvaluator.java: Ditto. This breaks the build since frysk-gui still thinks that various methods throw this exception and try to catch it. The following patch fixes the build. 2007-09-13 Mark Wielaard * SourceView.java (clickedOnTextArea): Don't catch NameNotFoundException. * SourceBuffer.java (getVariable): Likewise. * InlineSourceView.java (mouseEvent): Likewise. * InlineBuffer.java (getVariable): Likewise. A quick test run of FryskGui looks fine. But switching source buffers (clicking on different frames in the stack associated with functions in different source files) is super slow. I don't know if that was also that way before and currently working over remote X which is naturally slow. Maybe someone could double check that the error handling in these code paths is sane. Cheers, Mark --=-WrUAFyo4/5sT6ccYVjWt Content-Disposition: inline; filename=gui-name-exception.patch Content-Type: text/x-patch; name=gui-name-exception.patch; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-length: 4442 Index: frysk-gui/frysk/gui/srcwin/SourceView.java =================================================================== RCS file: /cvs/frysk/frysk-gui/frysk/gui/srcwin/SourceView.java,v retrieving revision 1.64 diff -u -r1.64 SourceView.java --- frysk-gui/frysk/gui/srcwin/SourceView.java 30 Aug 2007 19:28:23 -0000 1.64 +++ frysk-gui/frysk/gui/srcwin/SourceView.java 13 Oct 2007 18:15:15 -0000 @@ -1,6 +1,6 @@ // This file is part of the program FRYSK. // -// Copyright 2005, Red Hat Inc. +// Copyright 2005, 2007 Red Hat Inc. // // FRYSK is free software; you can redistribute it and/or modify it // under the terms of the GNU General Public License as published by @@ -43,8 +43,6 @@ import java.util.HashMap; import java.util.List; -import javax.naming.NameNotFoundException; - import org.gnu.gdk.Color; import org.gnu.gdk.Cursor; import org.gnu.gdk.CursorType; @@ -894,8 +892,6 @@ } catch (ParseException e) { System.out.println(e.getMessage()); - } catch (NameNotFoundException n) { - System.err.println(n.getMessage()); } valueItem = new MenuItem("Value of " + varText + ": " Index: frysk-gui/frysk/gui/srcwin/SourceBuffer.java =================================================================== RCS file: /cvs/frysk/frysk-gui/frysk/gui/srcwin/SourceBuffer.java,v retrieving revision 1.139 diff -u -r1.139 SourceBuffer.java --- frysk-gui/frysk/gui/srcwin/SourceBuffer.java 30 Aug 2007 19:28:23 -0000 1.139 +++ frysk-gui/frysk/gui/srcwin/SourceBuffer.java 13 Oct 2007 18:15:15 -0000 @@ -49,8 +49,6 @@ import java.util.LinkedList; import java.util.List; -import javax.naming.NameNotFoundException; - import lib.opcodes.Disassembler; import lib.opcodes.Instruction; @@ -651,9 +649,6 @@ } catch (ParseException e) { System.out.println(e.getMessage()); return null; - } catch (NameNotFoundException n) { - System.err.println(n.getMessage()); - return null; } return getWordAtIter(iter); @@ -682,9 +677,6 @@ } catch (ParseException e) { System.out.println(e.getMessage()); return null; - } catch (NameNotFoundException n) { - // n.printStackTrace(); - return null; } return var; Index: frysk-gui/frysk/gui/srcwin/InlineSourceView.java =================================================================== RCS file: /cvs/frysk/frysk-gui/frysk/gui/srcwin/InlineSourceView.java,v retrieving revision 1.21 diff -u -r1.21 InlineSourceView.java --- frysk-gui/frysk/gui/srcwin/InlineSourceView.java 30 Aug 2007 19:28:23 -0000 1.21 +++ frysk-gui/frysk/gui/srcwin/InlineSourceView.java 13 Oct 2007 18:15:15 -0000 @@ -1,6 +1,6 @@ // This file is part of the program FRYSK. // -// Copyright 2005, Red Hat Inc. +// Copyright 2005, 2007 Red Hat Inc. // // FRYSK is free software; you can redistribute it and/or modify it // under the terms of the GNU General Public License as published by @@ -40,8 +40,6 @@ import java.text.ParseException; -import javax.naming.NameNotFoundException; - import org.gnu.gdk.GC; import org.gnu.gdk.Point; import org.gnu.gdk.Window; @@ -259,8 +257,6 @@ } catch (ParseException e) { System.out.println(e.getMessage()); - } catch (NameNotFoundException n) { - System.err.println(n.getMessage()); } valueItem = new MenuItem("Value: " + var.toPrint(), true); valueItem.setSensitive(false); Index: frysk-gui/frysk/gui/srcwin/InlineBuffer.java =================================================================== RCS file: /cvs/frysk/frysk-gui/frysk/gui/srcwin/InlineBuffer.java,v retrieving revision 1.52 diff -u -r1.52 InlineBuffer.java --- frysk-gui/frysk/gui/srcwin/InlineBuffer.java 30 Aug 2007 19:28:23 -0000 1.52 +++ frysk-gui/frysk/gui/srcwin/InlineBuffer.java 13 Oct 2007 18:15:15 -0000 @@ -1,6 +1,6 @@ // This file is part of the program FRYSK. // -// Copyright 2005, Red Hat Inc. +// Copyright 2005, 2007 Red Hat Inc. // // FRYSK is free software; you can redistribute it and/or modify it // under the terms of the GNU General Public License as published by @@ -43,8 +43,6 @@ import java.text.ParseException; import java.util.Iterator; -import javax.naming.NameNotFoundException; - import org.gnu.gtk.TextChildAnchor; import org.gnu.gtk.TextIter; import org.jdom.Element; @@ -225,10 +223,6 @@ { return null; } - catch (NameNotFoundException n) - { - return null; - } return getWordAtIter(iter); } --=-WrUAFyo4/5sT6ccYVjWt--