From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19426 invoked by alias); 26 Oct 2007 15:12:32 -0000 Received: (qmail 19413 invoked by uid 22791); 26 Oct 2007 15:12:31 -0000 X-Spam-Status: No, hits=0.8 required=5.0 tests=AWL,BAYES_00,DK_POLICY_SIGNSOME,FORGED_RCVD_HELO,KAM_STOCKTIP,TW_CB,TW_XC X-Spam-Check-By: sourceware.org Received: from wildebeest.demon.nl (HELO gnu.wildebeest.org) (83.160.170.119) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 26 Oct 2007 15:12:28 +0000 Received: from wildebeest.demon.nl ([83.160.170.119] helo=[127.0.0.1]) by gnu.wildebeest.org with esmtp (Exim 4.63) (envelope-from ) id 1IlQrJ-0000kG-1k for frysk@sourceware.org; Fri, 26 Oct 2007 17:12:26 +0200 Subject: Re: frysk-imports frysk/pkglibdir/ChangeLog frysk/ ... From: Mark Wielaard To: frysk@sourceware.org In-Reply-To: <20071015180147.24121.qmail@sourceware.org> References: <20071015180147.24121.qmail@sourceware.org> Content-Type: text/plain Date: Fri, 26 Oct 2007 15:12:00 -0000 Message-Id: <1193411543.2931.8.camel@hermans.wildebeest.org> Mime-Version: 1.0 X-Mailer: Evolution 2.12.1 (2.12.1-3.fc8) Content-Transfer-Encoding: 7bit X-Spam-Score: -4.1 (----) X-IsSubscribed: yes Mailing-List: contact frysk-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: frysk-owner@sourceware.org X-SW-Source: 2007-q4/txt/msg00078.txt.bz2 Hi Andrew, On Mon, 2007-10-15 at 18:01 +0000, cagney@sourceware.org wrote: > 2007-10-15 Andrew Cagney > > * RegsCase.java (taskObject(Task)): Delete. > (access(Register,int,int,byte[],int,boolean)): Relace > accessRegister(Object,Register,int,int,byte[],int,boolean). > (Value, ByteValue, BigIntegerValue, MaskedValue, SymbolValue) > (NoValue): New. > (Values): Replace ValueMap. > (IA32): Provide values for EIP and maksed EFLAGS. > * TestRegs.java: Update. Being able to use a mask for some of the registers is useful. Thanks. The EFLAGS mask was off by one because the bit values start at zero. The following makes the test also pass on my machine (Intel x86 T2400). 2007-10-26 Mark Wielaard * RegsCase.java (IA32): Don't subtract one from EFLAGS bit mask. Cheers, Mark diff --git a/frysk-core/frysk/testbed/RegsCase.java b/frysk-core/frysk/testbed/R index c94613d..2078cff 100644 --- a/frysk-core/frysk/testbed/RegsCase.java +++ b/frysk-core/frysk/testbed/RegsCase.java @@ -288,7 +288,7 @@ public abstract class RegsCase extends TestLib { .put(IA32Registers.EBP, // 0xcbfed73c new byte[] { 0x3c, (byte)0xd7, (byte)0xfe, (byte)0xcb }) .put(IA32Registers.EFLAGS, 0x10246, - 1 << (21 - 1) // Mask CPUID + 1 << 21 // Mask CPUID ) .put(IA32Registers.ESP, // 0x93d4a6ed new byte[] { (byte)0xed, (byte)0xa6, (byte)0xd4, (byte)0x93 })