public inbox for frysk@sourceware.org
 help / color / mirror / Atom feed
From: Mark Wielaard <mark@klomp.org>
To: Tim Moore <timoore@redhat.com>
Cc: frysk <frysk@sourceware.org>
Subject: Re: frysk git repository
Date: Fri, 26 Oct 2007 16:57:00 -0000	[thread overview]
Message-ID: <1193417804.2931.25.camel@hermans.wildebeest.org> (raw)
In-Reply-To: <472216B9.5090600@redhat.com>

Hi Tim,

On Fri, 2007-10-26 at 18:32 +0200, Tim Moore wrote:
> > Is there a way to include the actual diffs of the patches that are
> > pushed into the repo to the commit list to make reviewing changes
> > easier?
> 
> I can tweak the script, but I think that falls into the category of "too much information"
> since you can review the changes locally using either the git command line tools or
> gitk.

There is never too much information! Including it in the email would be
way easier for people to review and comment on them when the patches
actually happen. Could you add some easy way in the commit mail to see
the actual patches? Then people could compare and see what is easiest to
work with for them.

Also, would it be possible to tweak the subject to start with the
oneline commit message?

Thanks,

Mark

  reply	other threads:[~2007-10-26 16:57 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-24 17:09 Tim Moore
2007-10-24 17:20 ` Elena Zannoni
2007-10-25  4:50   ` Tim Moore
2007-10-24 19:51 ` Mark Wielaard
2007-10-24 20:05   ` Mark Wielaard
2007-10-25  4:48     ` Tim Moore
2007-10-25 20:10 ` Andrew Cagney
2007-10-26 14:52 ` frysk git repository (workflow) Sami Wagiaalla
2007-10-27 17:58   ` Tim Moore
2007-10-26 14:59 ` frysk git repository Mark Wielaard
2007-10-26 16:33   ` Tim Moore
2007-10-26 16:57     ` Mark Wielaard [this message]
2007-10-26 18:38       ` Sami Wagiaalla
2007-10-29  8:19         ` Mark Wielaard
2007-10-30 17:20           ` Andrew Cagney
2007-10-26 16:35   ` Tim Moore

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1193417804.2931.25.camel@hermans.wildebeest.org \
    --to=mark@klomp.org \
    --cc=frysk@sourceware.org \
    --cc=timoore@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).