From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30541 invoked by alias); 27 Nov 2007 08:25:51 -0000 Received: (qmail 30438 invoked by uid 22791); 27 Nov 2007 08:25:50 -0000 X-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,DK_POLICY_SIGNSOME,FORGED_RCVD_HELO X-Spam-Check-By: sourceware.org Received: from wildebeest.demon.nl (HELO gnu.wildebeest.org) (83.160.170.119) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 27 Nov 2007 08:25:45 +0000 Received: from dijkstra.wildebeest.org ([192.168.1.29]) by gnu.wildebeest.org with esmtp (Exim 4.63) (envelope-from ) id 1IwvlG-0001qp-BI; Tue, 27 Nov 2007 09:25:42 +0100 Subject: Re: Quick pc hack for exe loading From: Mark Wielaard To: Andrew Cagney Cc: Rick Moseley , frysk@sourceware.org In-Reply-To: <474AF9C2.2080607@redhat.com> References: <1195817730.2981.21.camel@dijkstra.wildebeest.org> <47470A62.3070906@redhat.com> <47470E4C.5040307@redhat.com> <1196073636.3088.17.camel@dijkstra.wildebeest.org> <474AF9C2.2080607@redhat.com> Content-Type: text/plain Date: Tue, 27 Nov 2007 08:25:00 -0000 Message-Id: <1196151942.3054.5.camel@dijkstra.wildebeest.org> Mime-Version: 1.0 X-Mailer: Evolution 2.12.1 (2.12.1-3.fc8) Content-Transfer-Encoding: 7bit X-Spam-Score: -4.4 (----) X-IsSubscribed: yes Mailing-List: contact frysk-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: frysk-owner@sourceware.org X-SW-Source: 2007-q4/txt/msg00181.txt.bz2 Hi Andrew, On Mon, 2007-11-26 at 11:52 -0500, Andrew Cagney wrote: > The comment for getRegisterBuffers notes: > > protected abstract ByteBuffer[] sendrecRegisterBuffersFIXME(); > /** > * Return the machine's register banks as an array. > * > * XXX: This is being replaced by "getRegisterBanks()" that returns > * a class that abstracts the ByteArray[] + BankRegister > * combination. > */ > public ByteBuffer[] getRegisterBuffersFIXME () > > what prevents the use of getRegisterBanks()? Right that is the question. Since you introduced the FIXMEs and are working on this refactoring I assumed that you would fix it when you were ready and nothing prevented it anymore. Which is the reason I didn't change it myself. Cheers, Mark