public inbox for frysk@sourceware.org
 help / color / mirror / Atom feed
From: Zhao Shujing <pearly.zhao@oracle.com>
To: Andrew Cagney <cagney@redhat.com>
Cc: frysk@sourceware.org
Subject: Re: [SCM]  master: Add a test 	testMemoryBufferCapacity()	to	TestByteBuffer.java
Date: Wed, 28 Nov 2007 08:21:00 -0000	[thread overview]
Message-ID: <1196238270.19305.2.camel@linux-pzhao.site> (raw)
In-Reply-To: <474C2D7A.8020109@redhat.com>

It's been updated and the test is passing now.
On Tue, 2007-11-27 at 09:45 -0500, Andrew Cagney wrote:
> Zhao Shujing wrote:
> > Sorry, this test is added for bug 1538. I think .capacity() can use for
> > test if highWater mark is the top location when map memory to
> > ByteBuffer.
> >   
> True; however did you see:
> 
> > +               = new ExecOffspring(new ExecCommand (new String[] {
> > +                                                "/bin/rm",
> > +                                                tmpFile.toString()
> >   
> >   
> > I'm not sure that ExecOffspring is what you need here as it doesn't put 
> > the task into an attached/stopped state; I suspect:
> >    Task = new DaemonBlockedAtEntry("funit-slave").getMainTask().getISA();
> > be simpler?
> and:
> 
> > +       Task task = child.findTaskUsingRefresh(true);
> > +       if (task.getISA() == ISA.IA32)
> > +               assertEquals("Memory Buffer Capacity: ", 0xffffffffL,
> > +                    task.getMemory().capacity());
> > +       if (task.getISA() == ISA.X8664)
> > +               assertEquals("Memory Buffer Capacity: ",
> > 0xffffffffffffffffL,
> > +                     task.getMemory().capacity());
> >      }
> >   
> >   
> > There is also the PPC;  the attribute is dependent on the ISA's word 
> > size, though, is something like:
> >   switch (task.getISA().wordSize())
> >      case 4: assert ... ; break;
> >     case 8: assert ... ; break;
> >      default: fail("unknown word size");
> >   }
> > simplier?
> >
> > is the test passing or still being skipped?
> can we address these?
> 
> Andrew
> 

  reply	other threads:[~2007-11-28  8:21 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20071122090733.7335.qmail@sourceware.org>
2007-11-22 17:10 ` Andrew Cagney
2007-11-23  4:10   ` Zhao Shujing
2007-11-24  0:07     ` Andrew Cagney
2007-11-26  2:53       ` Zhao Shujing
2007-11-27 14:45         ` Andrew Cagney
2007-11-28  8:21           ` Zhao Shujing [this message]
2007-11-29 10:37             ` Mark Wielaard
2007-11-29 10:44               ` Mark Wielaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1196238270.19305.2.camel@linux-pzhao.site \
    --to=pearly.zhao@oracle.com \
    --cc=cagney@redhat.com \
    --cc=frysk@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).