From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18725 invoked by alias); 1 Mar 2008 18:16:59 -0000 Received: (qmail 18701 invoked by uid 22791); 1 Mar 2008 18:16:58 -0000 X-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from wildebeest.demon.nl (HELO gnu.wildebeest.org) (83.160.170.119) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 01 Mar 2008 18:16:40 +0000 Received: from wildebeest.demon.nl ([83.160.170.119] helo=[127.0.0.1]) by gnu.wildebeest.org with esmtp (Exim 4.63) (envelope-from ) id 1JVWGC-0005J9-Sr; Sat, 01 Mar 2008 19:16:37 +0100 Subject: Re: minor frysk cleanup From: Mark Wielaard To: tromey@redhat.com Cc: Frysk List In-Reply-To: References: Content-Type: text/plain Date: Sat, 01 Mar 2008 18:16:00 -0000 Message-Id: <1204395396.3279.31.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.12.3 (2.12.3-1.fc8) Content-Transfer-Encoding: 7bit X-Spam-Score: -4.2 (----) X-IsSubscribed: yes Mailing-List: contact frysk-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: frysk-owner@sourceware.org X-SW-Source: 2008-q1/txt/msg00091.txt.bz2 Hi Tom, On Fri, 2008-02-29 at 13:19 -0700, Tom Tromey wrote: > I was looking at frysk a little today and noticed an oddity in > FlowControlWriter. This class keeps its own copy of the output > writer, but there is no reason to do this. FilterWriter subclasses > should either use super calls or the inherited "out" field. > > frysk-core/frysk/util/ChangeLog: > 2008-02-29 Tom Tromey > > * FlowControlWriter.java (outStream): Remove. > (FlowControlWriter): Update. > (flush): Update. > (close): Update. > (write(char[],int,int)): Update. > (write(int)): Update. > (write(String,int,int)): Update. This looks good. Thanks. If you have git push access please push it. Otherwise I can do that for you. It does help if you run make check in at least frysk-core (or make check -k toplevel) and mention whether you see any failures (normally we should have zero fails, at least in frysk-core). Cheers, Mark