From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1286 invoked by alias); 1 Mar 2008 19:22:33 -0000 Received: (qmail 1231 invoked by uid 22791); 1 Mar 2008 19:22:32 -0000 X-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from wildebeest.demon.nl (HELO gnu.wildebeest.org) (83.160.170.119) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 01 Mar 2008 19:22:15 +0000 Received: from wildebeest.demon.nl ([83.160.170.119] helo=[127.0.0.1]) by gnu.wildebeest.org with esmtp (Exim 4.63) (envelope-from ) id 1JVXHf-0005cB-Nr; Sat, 01 Mar 2008 20:22:12 +0100 Subject: Re: minor frysk cleanup From: Mark Wielaard To: Tom Tromey Cc: Frysk List In-Reply-To: References: <1204395396.3279.31.camel@localhost.localdomain> Content-Type: text/plain Date: Sat, 01 Mar 2008 19:22:00 -0000 Message-Id: <1204399331.3279.34.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.12.3 (2.12.3-1.fc8) Content-Transfer-Encoding: 7bit X-Spam-Score: -4.1 (----) X-IsSubscribed: yes Mailing-List: contact frysk-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: frysk-owner@sourceware.org X-SW-Source: 2008-q1/txt/msg00093.txt.bz2 Hi Tom, On Sat, 2008-03-01 at 10:37 -0700, Tom Tromey wrote: > Mark> This looks good. Thanks. > Mark> If you have git push access please push it. > Mark> Otherwise I can do that for you. > > I don't think I do. OK, I pushed it for you. > Mark> It does help if you run make check in at least frysk-core (or make check > Mark> -k toplevel) and mention whether you see any failures (normally we > Mark> should have zero fails, at least in frysk-core). > > I will run it now. As discussed on irc there are currently some failures :{ Those are not supposed to be there of course, normally we are pretty good at staying at zero fail. I checked that there were no regressions with your patch applied (same results before/after). Thanks, Mark Just for the record this is the failure list from frysk-core (fedora 8, x86): There were 2 unsupported: disassembler requires both 32-bit and 64-bit There were 3 failures: 1) testComplexStruct(frysk.value.TestClass)junit.framework.ComparisonFailure: Variable is a struct expected: but was: at frysk.value.TestClass.testComplexStruct(TestRunner) at frysk.junit.Runner.runCases(TestRunner) at frysk.junit.Runner.runTestCases(TestRunner) at TestRunner.main(TestRunner) 2) testInheritedStruct(frysk.value.TestClass)junit.framework.ComparisonFailure: Variable is a struct expected: but was: at frysk.value.TestClass.testInheritedStruct(TestRunner) at frysk.junit.Runner.runCases(TestRunner) at frysk.junit.Runner.runTestCases(TestRunner) at TestRunner.main(TestRunner) 3) testPublicPrivateType(frysk.value.TestComposite)junit.framework.ComparisonFailure: toPrint expected:<...public: ...> but was:<......> at frysk.value.TestComposite.testPublicPrivateType(TestRunner) at frysk.junit.Runner.runCases(TestRunner) at frysk.junit.Runner.runTestCases(TestRunner) at TestRunner.main(TestRunner) FAILURES!!! Tests run: 981, Failures: 3, Errors: 0 Failed after run #0 Exception in thread "main" FAIL: TestRunner java.lang.NullPointerException at FunitSimpleInterfaceTest.main(FunitSimpleInterfaceTest.java:46) Exception in thread "main" java.lang.NullPointerException at FunitSimpleInterfaceTest.main(FunitSimpleInterfaceTest.java:46) FAIL: frysk/pkglibdir/FunitSimpleInterfaceTest no suitable method `main' in class FAIL: frysk/rt/TestDisplayValue