From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13013 invoked by alias); 2 Mar 2008 12:34:47 -0000 Received: (qmail 13004 invoked by uid 22791); 2 Mar 2008 12:34:47 -0000 X-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_34 X-Spam-Check-By: sourceware.org Received: from wildebeest.demon.nl (HELO gnu.wildebeest.org) (83.160.170.119) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 02 Mar 2008 12:34:19 +0000 Received: from wildebeest.demon.nl ([83.160.170.119] helo=[127.0.0.1]) by gnu.wildebeest.org with esmtp (Exim 4.63) (envelope-from ) id 1JVnOS-0005bA-9E; Sun, 02 Mar 2008 13:34:16 +0100 Subject: Re: Patch: word-wrapping for 'help' output From: Mark Wielaard To: Tom Tromey Cc: Frysk List In-Reply-To: References: <1204409018.3279.56.camel@localhost.localdomain> Content-Type: text/plain Date: Sun, 02 Mar 2008 12:34:00 -0000 Message-Id: <1204461251.8622.12.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.12.3 (2.12.3-1.fc8) Content-Transfer-Encoding: 7bit X-Spam-Score: -4.0 (----) X-IsSubscribed: yes Mailing-List: contact frysk-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: frysk-owner@sourceware.org X-SW-Source: 2008-q1/txt/msg00104.txt.bz2 Hi Tom, On Sat, 2008-03-01 at 16:26 -0700, Tom Tromey wrote: > Mark> This could use a method description. > > You'll forgive me for assuming that the frysk style was not to write > javadoc. Documentation is really important. Especially later on when you look bad at code you might not have written yourself and try to figure out what and why it actually works. In this case I should probably have added it myself since I was reviewing the code anyway. Sorry I was a bit lazy. And thanks for picking it up! > Here's an add-on patch that adds javadoc. Let me know what you think. > I guess I should learn git enough to supply consolidated patches. This looks great! Don't worry too much about consolidating the patches. I'll commit them separately on top of each other and then push them in one go. It only really matter if the intermediate commits are bad (so you cannot bisect through them when searching when something broke). Some more git info and references can be found at: http://sourceware.org/frysk/build/git-fu.html > b/frysk-core/frysk/hpd/ChangeLog: > 2008-03-01 Tom Tromey > > * CLI.java (getWordWrapWriter): Document. > > b/frysk-core/frysk/util/ChangeLog: > 2008-03-01 Tom Tromey > > * WordWrapWriter.java: Document. Committed and will be pushed soon. Thanks, Mark