From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15638 invoked by alias); 2 Mar 2008 12:48:11 -0000 Received: (qmail 15631 invoked by uid 22791); 2 Mar 2008 12:48:10 -0000 X-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from wildebeest.demon.nl (HELO gnu.wildebeest.org) (83.160.170.119) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 02 Mar 2008 12:47:43 +0000 Received: from wildebeest.demon.nl ([83.160.170.119] helo=[127.0.0.1]) by gnu.wildebeest.org with esmtp (Exim 4.63) (envelope-from ) id 1JVnbQ-0005dX-Lf; Sun, 02 Mar 2008 13:47:41 +0100 Subject: Re: Patch: word-wrapping for 'help' output From: Mark Wielaard To: Tom Tromey Cc: Frysk List In-Reply-To: References: <1204409018.3279.56.camel@localhost.localdomain> Content-Type: text/plain Date: Sun, 02 Mar 2008 12:48:00 -0000 Message-Id: <1204462060.8622.20.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.12.3 (2.12.3-1.fc8) Content-Transfer-Encoding: 7bit X-Spam-Score: -4.0 (----) X-IsSubscribed: yes Mailing-List: contact frysk-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: frysk-owner@sourceware.org X-SW-Source: 2008-q1/txt/msg00105.txt.bz2 Hi Tom, On Sat, 2008-03-01 at 16:51 -0700, Tom Tromey wrote: > Mark> The CLI doesn't have the PtyTerminal (created in fhpd.java). > Mark> It might make sense to pass that to the CLI so it can use > Mark> getTerminalWidth() here when constructing the WordWrapWriter. > > Here's a patch to do it -- but *don't* check this in. > > getTerminalWidth seems to return something bogus, because everything > started wrapping at column 20. I didn't look into this any more > deeply. Hmmm. Might be a bug in jline I guess. I filed a bug for this issue pointing to this patch. http://sourceware.org/bugzilla/show_bug.cgi?id=5817 And a separate one for upgrading our jline in frysk-imports. http://sourceware.org/bugzilla/show_bug.cgi?id=5816 Hopefully it contains a fix. I didn't check though. We are still using a fairly old 0.6 release of jline, while current upstream is 0.9.3. Tim might know the story. I believe a newer version didn't compile cleanly and had to be reverted just before we pulled from git for a fedora release. Cheers, Mark