From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29353 invoked by alias); 5 Mar 2008 18:14:45 -0000 Received: (qmail 29330 invoked by uid 22791); 5 Mar 2008 18:14:44 -0000 X-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from wildebeest.demon.nl (HELO gnu.wildebeest.org) (83.160.170.119) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 05 Mar 2008 18:14:26 +0000 Received: from dijkstra.wildebeest.org ([192.168.1.29]) by gnu.wildebeest.org with esmtp (Exim 4.63) (envelope-from ) id 1JWy8E-0007fa-GJ; Wed, 05 Mar 2008 19:14:23 +0100 Subject: Re: Patch for PR 5809 From: Mark Wielaard To: Tom Tromey Cc: frysk@sourceware.org In-Reply-To: <18382.38977.407225.695512@fleche.redhat.com> References: <18382.38977.407225.695512@fleche.redhat.com> Content-Type: multipart/mixed; boundary="=-77WA3ws16pz4YxTVzj9L" Date: Wed, 05 Mar 2008 18:14:00 -0000 Message-Id: <1204740862.3367.108.camel@dijkstra.wildebeest.org> Mime-Version: 1.0 X-Mailer: Evolution 2.12.3 (2.12.3-1.fc8) X-Spam-Score: -4.4 (----) X-Virus-Checked: Checked by ClamAV on sourceware.org X-IsSubscribed: yes Mailing-List: contact frysk-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: frysk-owner@sourceware.org X-SW-Source: 2008-q1/txt/msg00133.txt.bz2 --=-77WA3ws16pz4YxTVzj9L Content-Type: text/plain Content-Transfer-Encoding: 7bit Content-length: 638 Hi Tom, On Wed, 2008-03-05 at 05:55 -0700, Tom Tromey wrote: > An earlier patch removed the Comparator, forgetting that that > Map.Entry is not comparable. > > I'm a little surprised nobody caught this before. If you have a > breakpoint and type "actions", you will get a stack trace. Yeah, there should have been written a testcase when this code was changed. I created one that fails before and succeeds after your patch (attached). > 2008-03-05 Tom Tromey > > Bug 5809 > * ActionPointCommands.java (Actions.interpret): Use Comparator to > sort the task set. Thanks, committed and pushed. Cheers, Mark --=-77WA3ws16pz4YxTVzj9L Content-Disposition: inline; filename=TestActionsCommand.java Content-Type: text/x-java; name=TestActionsCommand.java; charset=utf-8 Content-Transfer-Encoding: 7bit Content-length: 2655 // This file is part of the program FRYSK. // // Copyright 2008, Red Hat Inc. // // FRYSK is free software; you can redistribute it and/or modify it // under the terms of the GNU General Public License as published by // the Free Software Foundation; version 2 of the License. // // FRYSK is distributed in the hope that it will be useful, but // WITHOUT ANY WARRANTY; without even the implied warranty of // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU // General Public License for more details. // // You should have received a copy of the GNU General Public License // along with FRYSK; if not, write to the Free Software Foundation, // Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA. // // In addition, as a special exception, Red Hat, Inc. gives You the // additional right to link the code of FRYSK with code not covered // under the GNU General Public License ("Non-GPL Code") and to // distribute linked combinations including the two, subject to the // limitations in this paragraph. Non-GPL Code permitted under this // exception must only link to the code of FRYSK through those well // defined interfaces identified in the file named EXCEPTION found in // the source code files (the "Approved Interfaces"). The files of // Non-GPL Code may instantiate templates or use macros or inline // functions from the Approved Interfaces without causing the // resulting work to be covered by the GNU General Public // License. Only Red Hat, Inc. may make changes or additions to the // list of Approved Interfaces. You must obey the GNU General Public // License in all respects for all of the FRYSK code and other code // used in conjunction with FRYSK except the Non-GPL Code covered by // this exception. If you modify this file, you may extend this // exception to your version of the file, but you are not obligated to // do so. If you do not wish to provide this exception without // modification, you must delete this exception statement from your // version and license this file solely under the GPL without // exception. package frysk.hpd; public class TestActionsCommand extends TestLib { public void testBreakpointActionsCommand() { HpdTestbed hpd = new HpdTestbed(); hpd = HpdTestbed.load("funit-hello"); hpd.send("break print\n"); hpd.expect("breakpoint.*\n" + prompt); hpd.send("run\n"); hpd.expect("Breakpoint 0.*\n"); hpd.send("actions\n"); hpd.expect("actions.*\n"); hpd.expect("BREAKPOINTS.*\n"); hpd.expect("0 y print [0-9]+.*\n"); hpd.send("quit\n"); hpd.expect("quit.*\nQuitting..."); hpd.close(); } } --=-77WA3ws16pz4YxTVzj9L--