From: Mark Wielaard <mark@klomp.org>
To: Tom Tromey <tromey@redhat.com>
Cc: frysk@sourceware.org
Subject: Re: Patch for PR 5809
Date: Mon, 10 Mar 2008 10:16:00 -0000 [thread overview]
Message-ID: <1205144160.3356.11.camel@dijkstra.wildebeest.org> (raw)
In-Reply-To: <1204740862.3367.108.camel@dijkstra.wildebeest.org>
Hi,
On Wed, 2008-03-05 at 19:14 +0100, Mark Wielaard wrote:
> Yeah, there should have been written a testcase when this code was
> changed. I created one that fails before and succeeds after your patch
> (attached).
Here is a slightly better one that has tighter regexps for the expect
output. The original could sometimes gobble up too much output
through .* if it was already available. This expects the output more
stricly by explicitly matching the \r\n at the end of line output that
fhpd does.
frysk-core/frysk/hpd/ChangeLog
2008-03-10 Mark Wielaard <mwielaard@redhat.com>
* TestActionsCommand: Use tighter expect regular expressions.
Cheers,
Mark
diff --git a/frysk-core/frysk/hpd/TestActionsCommand.java b/frysk-core/frysk/hpd
index a01b9e8..b72be4d 100644
--- a/frysk-core/frysk/hpd/TestActionsCommand.java
+++ b/frysk-core/frysk/hpd/TestActionsCommand.java
@@ -47,15 +47,15 @@ public class TestActionsCommand extends TestLib {
hpd = HpdTestbed.load("funit-hello");
hpd.send("break print\n");
- hpd.expect("breakpoint.*\n" + prompt);
+ hpd.expect("breakpoint 0 deferred\r\n" + prompt);
hpd.send("run\n");
- hpd.expect("Breakpoint 0.*\n");
+ hpd.expect("Breakpoint 0 print 0x[0-9a-f]+\r\n");
- hpd.send("actions\n");
- hpd.expect("actions.*\n");
- hpd.expect("BREAKPOINTS.*\n");
- hpd.expect("0 y print [0-9]+.*\n");
+ hpd.send("actions\r\n");
+ hpd.expect("actions\r\n");
+ hpd.expect("BREAKPOINTS\r\n");
+ hpd.expect("0 y print [0-9]+ \r\n");
hpd.send("quit\n");
hpd.expect("quit.*\nQuitting...");
prev parent reply other threads:[~2008-03-10 10:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-05 13:51 Tom Tromey
2008-03-05 18:14 ` Mark Wielaard
2008-03-10 10:16 ` Mark Wielaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1205144160.3356.11.camel@dijkstra.wildebeest.org \
--to=mark@klomp.org \
--cc=frysk@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).